Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: update WebCryptoAPI WPT #47010

Merged
merged 1 commit into from
Mar 10, 2023
Merged

test,crypto: update WebCryptoAPI WPT #47010

merged 1 commit into from
Mar 10, 2023

Conversation

panva
Copy link
Member

@panva panva commented Mar 8, 2023

Just git node wpt WebCryptoAPI.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 8, 2023
@panva panva added crypto Issues and PRs related to the crypto subsystem. request-ci Add this label to start a Jenkins CI on a PR. webcrypto labels Mar 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50276/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50277/

aduh95
aduh95 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2023
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
This was referenced Mar 9, 2023
Open
Open
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 57c4070 into nodejs:main Mar 10, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 57c4070

@panva panva deleted the wpt-update-crypto branch March 10, 2023 10:53
This was referenced Mar 11, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@panva @targos
test,crypto: update WebCryptoAPI WPT
8886840 
PR-URL: #47010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@github-actions github-actions bot mentioned this pull request Mar 14, 2023
Open
24 tasks
targos pushed a commit that referenced this pull request Mar 14, 2023
@panva @targos
test,crypto: update WebCryptoAPI WPT
13f14a5 
PR-URL: #47010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@panva @danielleadams
test,crypto: update WebCryptoAPI WPT
5e008e7 
PR-URL: #47010
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadams danielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @anonrig @aduh95