Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo on esm loaders example #47015

Merged
merged 2 commits into from
Mar 10, 2023
Merged

doc: fix typo on esm loaders example #47015

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be9f99d
doc: fix typo on esm loaders example
ruyadorno Mar 8, 2023
d8760e7
Update doc/api/esm.md
ruyadorno Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,7 +1129,7 @@ export async function load(url, context, nextLoad) {
// file, search up the file system for the nearest parent package.json file
// and read its "type" field.
const format = await getPackageType(url);
// When a hook returns a format of 'commonjs', `source` is be ignored.
// When a hook returns a format of 'commonjs', `source` should be ignored.
ruyadorno marked this conversation as resolved.
Show resolved Hide resolved
// To handle CommonJS files, a handler needs to be registered with
// `require.extensions` in order to process the files with the CommonJS
// loader. Avoiding the need for a separate CommonJS handler is a future
Expand Down