src: use std::array for passing argv in node::url

[addaleax]

Implements a review suggestion from 72e971e.

Refs: #47001 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/url

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 403 Forbidden

https://github.com/nodejs/node/actions/runs/4385645549

[anonrig]

Can you run and share the benchmark?

[addaleax]

@anonrig Sure (why does this change differ from #47001 in that regard tho?):

$ node benchmark/compare.js --old ./node-before --new ./node --filter url-parse url | Rscript benchmark/compare.R
[00:25:29|% 100| 2/2 files | 60/60 runs | 2/2 configs]: Done
                                                                                          confidence improvement accuracy (*)   (**)  (***)
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='auth' withBase='false'                      -1.62 %       ±2.61% ±3.48% ±4.53%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='auth' withBase='true'                       -1.92 %       ±3.42% ±4.55% ±5.92%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='dot' withBase='false'                       -1.48 %       ±2.39% ±3.18% ±4.14%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='dot' withBase='true'                        -0.59 %       ±2.90% ±3.86% ±5.04%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='file' withBase='false'                       0.21 %       ±1.82% ±2.42% ±3.15%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='file' withBase='true'                       -0.25 %       ±2.10% ±2.80% ±3.64%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='idn' withBase='false'                        1.24 %       ±1.33% ±1.78% ±2.31%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='idn' withBase='true'                         0.28 %       ±1.61% ±2.15% ±2.80%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='javascript' withBase='false'                -1.71 %       ±1.97% ±2.62% ±3.41%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='javascript' withBase='true'                 -0.80 %       ±2.19% ±2.91% ±3.79%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='long' withBase='false'                      -1.69 %       ±2.83% ±3.77% ±4.91%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='long' withBase='true'                       -0.63 %       ±2.68% ±3.58% ±4.67%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='percent' withBase='false'                   -1.85 %       ±2.05% ±2.73% ±3.56%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='percent' withBase='true'                     0.56 %       ±1.89% ±2.52% ±3.28%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='short' withBase='false'               *      1.93 %       ±1.87% ±2.51% ±3.29%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='short' withBase='true'                      -1.39 %       ±1.81% ±2.40% ±3.13%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='wpt' withBase='false'                        0.73 %       ±0.80% ±1.07% ±1.40%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='wpt' withBase='true'                ***      1.32 %       ±0.72% ±0.96% ±1.25%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='ws' withBase='false'                        -0.94 %       ±3.00% ±4.00% ±5.20%
url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='ws' withBase='true'                          1.35 %       ±3.83% ±5.10% ±6.65%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='auth' withBase='false'                       0.72 %       ±1.87% ±2.49% ±3.24%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='auth' withBase='true'                       -0.52 %       ±1.58% ±2.11% ±2.74%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='dot' withBase='false'                 *      2.27 %       ±1.92% ±2.56% ±3.33%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='dot' withBase='true'                        -1.18 %       ±1.35% ±1.79% ±2.34%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='file' withBase='false'                       0.87 %       ±1.90% ±2.53% ±3.29%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='file' withBase='true'                        1.08 %       ±1.58% ±2.10% ±2.73%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='idn' withBase='false'                       -0.09 %       ±1.25% ±1.67% ±2.17%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='idn' withBase='true'                         0.80 %       ±1.44% ±1.91% ±2.49%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='javascript' withBase='false'                -0.83 %       ±1.52% ±2.03% ±2.64%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='javascript' withBase='true'                  0.71 %       ±1.79% ±2.39% ±3.11%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='long' withBase='false'                       1.08 %       ±1.45% ±1.93% ±2.51%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='long' withBase='true'                        0.36 %       ±1.06% ±1.41% ±1.84%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='percent' withBase='false'                    0.83 %       ±1.71% ±2.28% ±2.96%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='percent' withBase='true'                     0.07 %       ±1.88% ±2.51% ±3.28%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='short' withBase='false'                      0.23 %       ±1.54% ±2.06% ±2.68%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='short' withBase='true'                       0.25 %       ±1.60% ±2.13% ±2.78%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='wpt' withBase='false'                        0.59 %       ±0.66% ±0.88% ±1.15%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='wpt' withBase='true'                        -0.02 %       ±1.19% ±1.58% ±2.06%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='ws' withBase='false'                ***      2.95 %       ±1.60% ±2.13% ±2.78%
url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='ws' withBase='true'                   *     -1.63 %       ±1.59% ±2.12% ±2.76%
url/url-parse.js n=10000000 type='escaped'                                                      ***     -1.19 %       ±0.53% ±0.71% ±0.92%
url/url-parse.js n=10000000 type='normal'                                                       ***     -1.79 %       ±0.86% ±1.15% ±1.50%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 42 comparisons, you can thus
expect the following amount of false-positive results:
  2.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.42 false positives, when considering a   1% risk acceptance (**, ***),
  0.04 false positives, when considering a 0.1% risk acceptance (***)

(That's more significant changes than one should see, both positive and negative. You can run a benchmark CI if you want reliable results.)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/50312/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/50323/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/50336/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/50353/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/50361/

[nodejs-github-bot]

Landed in f95d7c0

[danielleadams]

blocked by #46736