-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test,crypto: update WebCryptoAPI WPT #47222
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
Issues and PRs related to the crypto subsystem.
test
Issues and PRs related to the tests.
webcrypto
labels
Mar 22, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 22, 2023
anonrig
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 23, 2023
33 tasks
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Mar 23, 2023
lpinca
approved these changes
Mar 23, 2023
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 24, 2023
tniessen
approved these changes
Mar 24, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Mar 24, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47222 TypeError: fetch failed at fetch (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/node_modules/undici/index.js:109:13) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async getCollaborators (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/lib/collaborators.js:54:18) at async PRData.getCollaborators (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:74:26) at async Promise.all (index 0) at async PRData.getAll (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:58:5) at async getMetadata (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/components/metadata.js:18:3) at async main (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/components/git/land.js:200:22) { cause: Error: certificate has expired at TLSSocket.onConnectSecure (node:_tls_wrap:1540:34) at TLSSocket.emit (node:events:513:28) at TLSSocket._finishInit (node:_tls_wrap:959:8) at ssl.onhandshakedone (node:_tls_wrap:743:12) { code: 'CERT_HAS_EXPIRED' } }https://github.com/nodejs/node/actions/runs/4515294803 |
debadree25
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Mar 25, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Mar 25, 2023
Landed in a0ca15e |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #47222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47222 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just
git node wpt WebCryptoAPI
(again).