-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove non-exist build file #47361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
labels
Apr 1, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 1, 2023
cjihrig
approved these changes
Apr 1, 2023
30 tasks
lpinca
approved these changes
Apr 2, 2023
28 tasks
gengjiawen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 3, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Apr 3, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47361 ✔ Done loading data for nodejs/node/pull/47361 ----------------------------------- PR info ------------------------------------ Title build: remove non-exist build file (#47361) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:fix_code_files_sync -> nodejs:main Labels build, needs-ci Commits 1 - build: remove non-exist build file Committers 1 - gengjiawen PR-URL: https://github.com/nodejs/node/pull/47361 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47361 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 01 Apr 2023 09:12:09 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47361#pullrequestreview-1367866451 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47361#pullrequestreview-1368127414 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-04-01T13:45:30Z: https://ci.nodejs.org/job/node-test-pull-request/50789/ - Querying data for job/node-test-pull-request/50789/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4596289767 |
gengjiawen
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Apr 3, 2023
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Apr 3, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47361 ✔ Done loading data for nodejs/node/pull/47361 ----------------------------------- PR info ------------------------------------ Title build: remove non-exist build file (#47361) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:fix_code_files_sync -> nodejs:main Labels build, author ready, needs-ci Commits 1 - build: remove non-exist build file Committers 1 - gengjiawen PR-URL: https://github.com/nodejs/node/pull/47361 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47361 Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 01 Apr 2023 09:12:09 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47361#pullrequestreview-1367866451 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47361#pullrequestreview-1368127414 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-04-03T11:58:00Z: https://ci.nodejs.org/job/node-test-pull-request/50789/ - Querying data for job/node-test-pull-request/50789/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4597812296 |
29 tasks
gengjiawen
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Apr 4, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 4, 2023
Landed in 462fce2 |
RafaelGSS
added
backport-blocked-v16.x
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
labels
Apr 5, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47361 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backport-blocked-v18.x
PRs that should land on the v18.x-staging branch but are blocked by another PR's pending backport.
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.