tools: move update-undici.sh to dep_updaters and create brotli maintaining md #47380

marco-ippolito · 2023-04-03T09:59:54Z

Refs: nodejs/security-wg#828
@nodejs/undici
I'd also propose to create a folder under contributing that includes all maintaining files
@nodejs/security-wg

nodejs-github-bot · 2023-04-03T09:59:59Z

Review requested:

@nodejs/actions
@nodejs/tsc

tools/dep_updaters/update-undici.sh

aduh95

You need to either add spaces or remove the empty line so the code snippet is inside the list.

doc/contributing/maintaining-undici.md

doc/contributing/maintaining-brotli.md

targos · 2023-04-03T11:21:07Z

Can you please make the commit message clearer?

RafaelGSS

The title says maintaining undici, but you are adding maintaining-brotli as well. Could you please adjust it?

ShogunPanda

LGTM!

nodejs-github-bot · 2023-04-10T19:46:03Z

Commit Queue failed

- Loading data for nodejs/node/pull/47380 ✔ Done loading data for nodejs/node/pull/47380 ----------------------------------- PR info ------------------------------------ Title tools: move update-undici.sh to dep_updaters and create brotli maintaining md (#47380) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/improve-deps-update -> nodejs:main Labels meta, tools, author ready, commit-queue-rebase Commits 2 - doc: create maintaining-brotli.md - tools: move update-undici.sh to dep_updaters and create maintaining-u… Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47380 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Yagiz Nizipli Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47380 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Yagiz Nizipli Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Apr 2023 09:59:54 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47380#pullrequestreview-1369790275 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376060783 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376541837 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47380#pullrequestreview-1378029737 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47380 From https://github.com/nodejs/node * branch refs/pull/47380/merge -> FETCH_HEAD ✔ Fetched commits as 9d9cf11a4bf8..a41e4f114fee -------------------------------------------------------------------------------- [main 0f59d9b17f] doc: create maintaining-brotli.md Author: Marco Ippolito Date: Mon Apr 3 10:50:40 2023 +0200 1 file changed, 26 insertions(+) create mode 100644 doc/contributing/maintaining-brotli.md Auto-merging .github/workflows/tools.yml [main 196d1ff98b] tools: move update-undici.sh to dep_updaters and create maintaining-undici.md Author: Marco Ippolito Date: Mon Apr 3 11:52:59 2023 +0200 6 files changed, 56 insertions(+), 20 deletions(-) create mode 100644 doc/contributing/maintaining-undici.md rename tools/{ => dep_updaters}/update-undici.sh (60%) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: create maintaining-brotli.md

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 102106be53] doc: create maintaining-brotli.md
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon Apr 3 10:50:40 2023 +0200
1 file changed, 26 insertions(+)
create mode 100644 doc/contributing/maintaining-brotli.md
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: move update-undici.sh to dep_updaters and create maintaining-undici.md

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD c329e295e3] tools: move update-undici.sh to dep_updaters and create maintaining-undici.md
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon Apr 3 11:52:59 2023 +0200
6 files changed, 56 insertions(+), 20 deletions(-)
create mode 100644 doc/contributing/maintaining-undici.md
rename tools/{ => dep_updaters}/update-undici.sh (60%)

Successfully rebased and updated refs/heads/main.

✔ 102106be532a24c290022a1a1b410877ea4703ce
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ c329e295e396949257f32ace7a64995c4796e223
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✖ 0:72 Title must be <= 72 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/4660665489

nodejs-github-bot · 2023-04-11T09:21:07Z

Commit Queue failed

- Loading data for nodejs/node/pull/47380 ✔ Done loading data for nodejs/node/pull/47380 ----------------------------------- PR info ------------------------------------ Title tools: move update-undici.sh to dep_updaters and create brotli maintaining md (#47380) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/improve-deps-update -> nodejs:main Labels meta, tools, author ready Commits 2 - doc: create maintaining-brotli.md - tools: move update-undici.sh to dep_updaters and create maintaining-u… Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47380 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Yagiz Nizipli Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47380 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Yagiz Nizipli Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Apr 2023 09:59:54 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47380#pullrequestreview-1369790275 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376060783 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376541837 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47380#pullrequestreview-1378029737 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47380 From https://github.com/nodejs/node * branch refs/pull/47380/merge -> FETCH_HEAD ✔ Fetched commits as 97d3912eb8dd..a41e4f114fee -------------------------------------------------------------------------------- [main d8befc0c24] doc: create maintaining-brotli.md Author: Marco Ippolito Date: Mon Apr 3 10:50:40 2023 +0200 1 file changed, 26 insertions(+) create mode 100644 doc/contributing/maintaining-brotli.md Auto-merging .github/workflows/tools.yml [main ef512cffd6] tools: move update-undici.sh to dep_updaters and create maintaining-undici.md Author: Marco Ippolito Date: Mon Apr 3 11:52:59 2023 +0200 6 files changed, 56 insertions(+), 20 deletions(-) create mode 100644 doc/contributing/maintaining-undici.md rename tools/{ => dep_updaters}/update-undici.sh (60%) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: create maintaining-brotli.md

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD d2cd973187] doc: create maintaining-brotli.md
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon Apr 3 10:50:40 2023 +0200
1 file changed, 26 insertions(+)
create mode 100644 doc/contributing/maintaining-brotli.md
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: move update-undici.sh to dep_updaters and create maintaining-undici.md

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 6c2c6a3a5f] tools: move update-undici.sh to dep_updaters and create maintaining-undici.md
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon Apr 3 11:52:59 2023 +0200
6 files changed, 56 insertions(+), 20 deletions(-)
create mode 100644 doc/contributing/maintaining-undici.md
rename tools/{ => dep_updaters}/update-undici.sh (60%)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4665921327

nodejs-github-bot · 2023-04-11T09:29:22Z

Commit Queue failed

- Loading data for nodejs/node/pull/47380 ✔ Done loading data for nodejs/node/pull/47380 ----------------------------------- PR info ------------------------------------ Title tools: move update-undici.sh to dep_updaters and create brotli maintaining md (#47380) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/improve-deps-update -> nodejs:main Labels meta, tools, author ready, commit-queue-rebase Commits 2 - doc: create maintaining-brotli.md - tools: move update-undici.sh to dep_updaters and create maintaining-u… Committers 1 - Marco Ippolito PR-URL: https://github.com/nodejs/node/pull/47380 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Yagiz Nizipli Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47380 Refs: https://github.com/nodejs/security-wg/issues/828 Reviewed-By: Yagiz Nizipli Reviewed-By: Paolo Insogna Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Apr 2023 09:59:54 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47380#pullrequestreview-1369790275 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376060783 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376541837 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47380#pullrequestreview-1378029737 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47380 From https://github.com/nodejs/node * branch refs/pull/47380/merge -> FETCH_HEAD ✔ Fetched commits as 97d3912eb8dd..a41e4f114fee -------------------------------------------------------------------------------- [main cf836f3044] doc: create maintaining-brotli.md Author: Marco Ippolito Date: Mon Apr 3 10:50:40 2023 +0200 1 file changed, 26 insertions(+) create mode 100644 doc/contributing/maintaining-brotli.md Auto-merging .github/workflows/tools.yml [main 9533b8e3bf] tools: move update-undici.sh to dep_updaters and create maintaining-undici.md Author: Marco Ippolito Date: Mon Apr 3 11:52:59 2023 +0200 6 files changed, 56 insertions(+), 20 deletions(-) create mode 100644 doc/contributing/maintaining-undici.md rename tools/{ => dep_updaters}/update-undici.sh (60%) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: create maintaining-brotli.md

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 9e3a198f26] doc: create maintaining-brotli.md
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon Apr 3 10:50:40 2023 +0200
1 file changed, 26 insertions(+)
create mode 100644 doc/contributing/maintaining-brotli.md
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: move update-undici.sh to dep_updaters and create maintaining-undici.md

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 5bf535856b] tools: move update-undici.sh to dep_updaters and create maintaining-undici.md
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Mon Apr 3 11:52:59 2023 +0200
6 files changed, 56 insertions(+), 20 deletions(-)
create mode 100644 doc/contributing/maintaining-undici.md
rename tools/{ => dep_updaters}/update-undici.sh (60%)

Successfully rebased and updated refs/heads/main.

✔ 9e3a198f26ca67f910b77d317004b61a1526fa18
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
✖ 5bf535856b21f0491392aba6eba75b8c868b3358
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✖ 0:72 Title must be <= 72 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/4665993233

nodejs-github-bot · 2023-04-11T13:07:21Z

Commit Queue failed

- Loading data for nodejs/node/pull/47380
✔  Done loading data for nodejs/node/pull/47380
----------------------------------- PR info ------------------------------------
Title      tools: move update-undici.sh to dep_updaters and create brotli maintaining md (#47380)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/improve-deps-update -> nodejs:main
Labels     meta, tools, author ready, commit-queue-rebase
Commits    2
 - doc: create maintaining-brotli.md
 - tools: move update-undici.sh to dep_updaters and create maintain md
Committers 1
 - Marco Ippolito 
PR-URL: https://github.com/nodejs/node/pull/47380
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Paolo Insogna 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47380
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Paolo Insogna 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - tools: move update-undici.sh to dep_updaters and create maintain md
   ℹ  This PR was created on Mon, 03 Apr 2023 09:59:54 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47380#pullrequestreview-1369790275
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376060783
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47380#pullrequestreview-1376541837
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47380#pullrequestreview-1378029737
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/4667850921

nodejs-github-bot · 2023-04-11T13:19:16Z

Landed in 25ad49b...4899998

PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs#47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 3, 2023

marco-ippolito force-pushed the feat/improve-deps-update branch from f89a376 to 3fb789c Compare April 3, 2023 10:01

targos reviewed Apr 3, 2023

View reviewed changes

tools/dep_updaters/update-undici.sh Outdated Show resolved Hide resolved

aduh95 reviewed Apr 3, 2023

View reviewed changes

doc/contributing/maintaining-undici.md Outdated Show resolved Hide resolved

doc/contributing/maintaining-brotli.md Outdated Show resolved Hide resolved

marco-ippolito force-pushed the feat/improve-deps-update branch 2 times, most recently from 2fd443c to 335a979 Compare April 3, 2023 11:04

targos mentioned this pull request Apr 3, 2023

tools: move update-acorn.sh to dep_updaters #47382

Merged

doc: create maintaining-brotli.md

ce137c0

marco-ippolito force-pushed the feat/improve-deps-update branch 2 times, most recently from 1e1497a to a41e4f1 Compare April 3, 2023 12:44

RafaelGSS reviewed Apr 3, 2023

View reviewed changes

marco-ippolito changed the title ~~tools: maintaining undici~~ tools: updating undici and brotli deps update Apr 3, 2023

marco-ippolito changed the title ~~tools: updating undici and brotli deps update~~ tools: update undici and brotli deps update Apr 3, 2023

marco-ippolito changed the title ~~tools: update undici and brotli deps update~~ tools: move undici to dep_updaters and create brotli maintaining md Apr 3, 2023

marco-ippolito changed the title ~~tools: move undici to dep_updaters and create brotli maintaining md~~ tools: move update-undici.sh to dep_updaters and create brotli maintaining md Apr 3, 2023

anonrig approved these changes Apr 3, 2023

View reviewed changes

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2023

marco-ippolito requested review from RafaelGSS and targos April 7, 2023 09:00

ShogunPanda approved these changes Apr 7, 2023

View reviewed changes

RafaelGSS approved these changes Apr 7, 2023

View reviewed changes

lpinca approved these changes Apr 10, 2023

View reviewed changes

lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 10, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 10, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 11, 2023

tools: move update-undici.sh to dep_updaters and create maintain md

af2fc9e

marco-ippolito force-pushed the feat/improve-deps-update branch from a41e4f1 to af2fc9e Compare April 11, 2023 09:34

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 11, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 11, 2023

RafaelGSS approved these changes Apr 11, 2023

View reviewed changes

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 11, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023

nodejs-github-bot closed this Apr 11, 2023

targos mentioned this pull request May 2, 2023

v20.1.0 release proposal #47820

Merged

danielleadams mentioned this pull request Jul 10, 2023

v18.17.0 release proposal #48694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tools: move update-undici.sh to dep_updaters and create brotli maintaining md #47380

tools: move update-undici.sh to dep_updaters and create brotli maintaining md #47380

marco-ippolito commented Apr 3, 2023 •

edited

Loading

nodejs-github-bot commented Apr 3, 2023

aduh95 left a comment

targos commented Apr 3, 2023

RafaelGSS left a comment

ShogunPanda left a comment

nodejs-github-bot commented Apr 10, 2023

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 11, 2023

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 11, 2023

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 11, 2023

nodejs-github-bot commented Apr 11, 2023

tools: move update-undici.sh to dep_updaters and create brotli maintaining md #47380

tools: move update-undici.sh to dep_updaters and create brotli maintaining md #47380

Conversation

marco-ippolito commented Apr 3, 2023 • edited Loading

nodejs-github-bot commented Apr 3, 2023

aduh95 left a comment

Choose a reason for hiding this comment

targos commented Apr 3, 2023

RafaelGSS left a comment

Choose a reason for hiding this comment

ShogunPanda left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 10, 2023

PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 11, 2023

PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 11, 2023

PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Apr 11, 2023

nodejs-github-bot commented Apr 11, 2023

marco-ippolito commented Apr 3, 2023 •

edited

Loading

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

PR-URL: #47380
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com