doc: info on handling unintended breaking changes #47426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
lpinca
approved these changes
Apr 5, 2023
marco-ippolito
approved these changes
Apr 5, 2023
debadree25
approved these changes
Apr 5, 2023
debadree25
added
the
author ready
VoltrexKeyva
reviewed
Apr 6, 2023
benjamingr
approved these changes
Apr 6, 2023
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
RafaelGSS
approved these changes
Apr 8, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/47426 ✔ Done loading data for nodejs/node/pull/47426 ----------------------------------- PR info ------------------------------------ Title doc: info on handling unintended breaking changes (#47426) Author Michael Dawson (@mhdawson) Branch mhdawson:breaking-changes -> nodejs:main Labels doc, author ready Commits 2 - doc: info on handling unintended breaking changes - Update doc/contributing/collaborator-guide.md Committers 2 - Michael Dawson - GitHub PR-URL: https://github.com/nodejs/node/pull/47426 Fixes: https://github.com/nodejs/TSC/issues/1156 Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Debadree Chatterjee Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47426 Fixes: https://github.com/nodejs/TSC/issues/1156 Reviewed-By: Luigi Pinca Reviewed-By: Marco Ippolito Reviewed-By: Debadree Chatterjee Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 05 Apr 2023 19:12:04 GMT ✔ Approvals: 6 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47426#pullrequestreview-1373595089 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/47426#pullrequestreview-1373615386 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/47426#pullrequestreview-1373644856 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/47426#pullrequestreview-1374637778 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/47426#pullrequestreview-1376543820 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47426#pullrequestreview-1376789264 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47426 From https://github.com/nodejs/node * branch refs/pull/47426/merge -> FETCH_HEAD ✔ Fetched commits as 491a5c968fd4..4410a2875487 -------------------------------------------------------------------------------- [main 9ad35bbb95] doc: info on handling unintended breaking changes Author: Michael Dawson Date: Wed Apr 5 15:04:42 2023 -0400 1 file changed, 18 insertions(+) [main 22ebdb5d4c] Update doc/contributing/collaborator-guide.md Author: Michael Dawson Date: Thu Apr 6 11:14:25 2023 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/4651978867 |
lpinca
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6c76d7e |
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 13, 2023
Fixes: nodejs/TSC#1156 PR-URL: #47426 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Fixes: nodejs/TSC#1156 PR-URL: #47426 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Fixes: nodejs/TSC#1156 PR-URL: nodejs#47426 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/TSC#1156