Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix split infinitive in Hooks caveat #47550

Merged
merged 1 commit into from
Apr 13, 2023
Merged

doc: fix split infinitive in Hooks caveat #47550

merged 1 commit into from
Apr 13, 2023

Conversation

JakobJingleheimer
Copy link
Member

No description provided.

@JakobJingleheimer JakobJingleheimer self-assigned this Apr 13, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 13, 2023
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 13, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 changed the title esm: correct split infinitive in Hooks caveat doc: unsplit infinitive in Hooks caveat Apr 13, 2023
@aduh95 aduh95 changed the title doc: unsplit infinitive in Hooks caveat doc: fix split infinitive in Hooks caveat Apr 13, 2023
@aduh95 aduh95 merged commit 1c3cbf3 into nodejs:main Apr 13, 2023
@aduh95
Copy link
Contributor

aduh95 commented Apr 13, 2023

Landed in 1c3cbf3

targos pushed a commit that referenced this pull request May 2, 2023
@JakobJingleheimer @targos
doc: fix split infinitive in Hooks caveat
0dc5080 
PR-URL: #47550
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targos targos mentioned this pull request May 2, 2023
Merged
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Jun 27, 2023
@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@MoLow MoLow MoLow approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees

@JakobJingleheimer JakobJingleheimer

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JakobJingleheimer @nodejs-github-bot @aduh95 @GeoffreyBooth @MoLow @targos @danielleadams