Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: harden check for non-module in vm.modules linker #47583

Closed
wants to merge 2 commits into from
Closed

fix: harden check for non-module in vm.modules linker #47583

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1586f93
vm: harden check for non-module in vm.modules linker
MikeRalphson Apr 16, 2023
ac3d903
vm: use more idiomatic test for undefined
MikeRalphson Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/vm/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ class SourceTextModule extends Module {

const promises = this[kWrap].link(async (identifier, assert) => {
const module = await linker(identifier, this, { assert });
if (module[kWrap] === undefined) {
if (module === undefined || module[kWrap] === undefined) {
MikeRalphson marked this conversation as resolved.
Show resolved Hide resolved
throw new ERR_VM_MODULE_NOT_MODULE();
}
if (module.context !== this.context) {
Expand Down