Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add option to run workflow with specific tool id #47591

Merged
merged 1 commit into from
Apr 19, 2023
Merged

tools: add option to run workflow with specific tool id #47591

merged 1 commit into from
Apr 19, 2023

Conversation

targos
Copy link
Member

@targos targos commented Apr 17, 2023

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 17, 2023
@targos targos force-pushed the tools-deps-select branch from c901785 to 0bcea28 Compare April 17, 2023 09:31
MoLow
MoLow approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

marco-ippolito
marco-ippolito approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 4f0e192 into nodejs:main Apr 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 4f0e192

@targos targos deleted the tools-deps-select branch April 19, 2023 09:37
@tniessen tniessen mentioned this pull request Apr 19, 2023
Merged
targos added a commit that referenced this pull request May 2, 2023
@targos
tools: add option to run workflow with specific tool id
7c552e6 
PR-URL: #47591
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@targos @danielleadams
tools: add option to run workflow with specific tool id
4858e19 
PR-URL: #47591
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@targos @MoLow
tools: add option to run workflow with specific tool id
4e1d87e 
PR-URL: nodejs#47591
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@MoLow MoLow MoLow approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnb bnb bnb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @nodejs-github-bot @bnb @lpinca @anonrig @tniessen @richardlau @MoLow @marco-ippolito @debadree25