Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update ada to 2.1.0 #47598

Merged
merged 1 commit into from
Apr 19, 2023
Merged

deps: update ada to 2.1.0 #47598

merged 1 commit into from
Apr 19, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Apr 17, 2023 •
edited by anonrig
Loading

This is an automated update of ada to 2.1.0.

Fixes #47555

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Apr 17, 2023
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Apr 17, 2023 •
edited by TimothyGu
Loading

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 17, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 17, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51312/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51318/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51321/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/51323/

@TimothyGu TimothyGu added the lts-watch-v18.x PRs that may need to be released in v18.x. label Apr 18, 2023
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Open
35 tasks
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 81c2a0d into main Apr 19, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 81c2a0d

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ada branch April 19, 2023 17:57
@fuxingloh fuxingloh mentioned this pull request Apr 25, 2023
Closed
targos pushed a commit that referenced this pull request May 2, 2023
@nodejs-github-bot @targos
deps: update ada to 2.1.0
3154543 
PR-URL: #47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
@KhafraDev KhafraDev mentioned this pull request May 22, 2023
Closed
@anonrig anonrig mentioned this pull request Jun 5, 2023
Closed
19 tasks
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
3ded56e 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
4deeb3d 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 5, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
b54b9f1 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@anonrig anonrig added the backport-open-v18.x Indicate that the PR has an open backport. label Jun 5, 2023
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 17, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
225a2d7 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 23, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
80a566c 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
a1ce58d 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 24, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
f3f7a85 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
fe86195 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jun 26, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
8a91e07 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 6, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
e06dfa9 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
439f620 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig pushed a commit to anonrig/node that referenced this pull request Jul 9, 2023
@nodejs-github-bot @anonrig
deps: update ada to 2.1.0
5e69ee9 
PR-URL: nodejs#47598
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@nodejs-github-bot @danielleadams
deps: update ada to 2.1.0
08dd271 
PR-URL: #47598
Backport-PR-URL: #48345
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 12, 2023
Merged
@danielleadams danielleadams added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-open-v18.x Indicate that the PR has an open backport. lts-watch-v18.x PRs that may need to be released in v18.x. labels Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KhafraDev KhafraDev KhafraDev approved these changes

@tniessen tniessen tniessen approved these changes

@anonrig anonrig anonrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@Trott Trott Trott approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL parser behaviour change in 18.16.0
8 participants
@nodejs-github-bot @panva @Trott @TimothyGu @anonrig @tniessen @KhafraDev @danielleadams