-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: keep PR titles/description up-to-date #47621
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:tools-pr-titles-description-update-pull-request-title-and-body
Apr 21, 2023
Merged
tools: keep PR titles/description up-to-date #47621
nodejs-github-bot
merged 1 commit into
nodejs:main
from
tniessen:tools-pr-titles-description-update-pull-request-title-and-body
Apr 21, 2023
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Apr 19, 2023
marco-ippolito
approved these changes
Apr 19, 2023
targos
approved these changes
Apr 19, 2023
richardlau
approved these changes
Apr 19, 2023
tniessen
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Apr 19, 2023
lpinca
approved these changes
Apr 19, 2023
jasnell
approved these changes
Apr 21, 2023
would you mind to add this param to https://github.com/nodejs/node/blob/main/.github/workflows/update-openssl.yml |
tniessen
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 21, 2023
Set the `update-pull-request-title-and-body` option when potentially updating an existing PR with a dynamic title and/or description.
tniessen
force-pushed
the
tools-pr-titles-description-update-pull-request-title-and-body
branch
from
April 21, 2023 14:12
695931d
to
aebda88
Compare
@marco-ippolito I believe I have now added the option to all relevant invocations. PTAL. |
marco-ippolito
approved these changes
Apr 21, 2023
tniessen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 21, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 21, 2023
Landed in 86a8335 |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
Set the `update-pull-request-title-and-body` option when potentially updating an existing PR with a dynamic title and/or description. PR-URL: #47621 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Set the `update-pull-request-title-and-body` option when potentially updating an existing PR with a dynamic title and/or description. PR-URL: #47621 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Set the `update-pull-request-title-and-body` option when potentially updating an existing PR with a dynamic title and/or description. PR-URL: nodejs#47621 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the
update-pull-request-title-and-body
option when potentially updating an existing PR with a dynamic title and/or description.Refs: #47482 (comment)