Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: keep PR titles/description up-to-date #47621

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Apr 19, 2023

Set the update-pull-request-title-and-body option when potentially updating an existing PR with a dynamic title and/or description.

Refs: #47482 (comment)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 19, 2023
@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2023
@marco-ippolito
Copy link
Member

@tniessen tniessen removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2023
Set the `update-pull-request-title-and-body` option when potentially
updating an existing PR with a dynamic title and/or description.
@tniessen tniessen force-pushed the tools-pr-titles-description-update-pull-request-title-and-body branch from 695931d to aebda88 Compare April 21, 2023 14:12
@tniessen
Copy link
Member Author

@marco-ippolito I believe I have now added the option to all relevant invocations. PTAL.

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 86a8335 into nodejs:main Apr 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 86a8335

targos pushed a commit that referenced this pull request May 2, 2023
Set the `update-pull-request-title-and-body` option when potentially
updating an existing PR with a dynamic title and/or description.

PR-URL: #47621
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Set the `update-pull-request-title-and-body` option when potentially
updating an existing PR with a dynamic title and/or description.

PR-URL: #47621
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Set the `update-pull-request-title-and-body` option when potentially
updating an existing PR with a dynamic title and/or description.

PR-URL: nodejs#47621
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants