-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typos in SECURITY.md #47677
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
VoltrexKeyva:security-fix-typos
Apr 23, 2023
Merged
doc: fix typos in SECURITY.md #47677
nodejs-github-bot
merged 1 commit into
nodejs:main
from
VoltrexKeyva:security-fix-typos
Apr 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daeyeon
approved these changes
Apr 23, 2023
deokjinkim
approved these changes
Apr 23, 2023
deokjinkim
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Apr 23, 2023
lpinca
approved these changes
Apr 23, 2023
Fast-track has been requested by @lpinca. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Apr 23, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47677 ✔ Done loading data for nodejs/node/pull/47677 ----------------------------------- PR info ------------------------------------ Title doc: fix typos in SECURITY.md (#47677) Author Mohammed Keyvanzadeh (@VoltrexKeyva) Branch VoltrexKeyva:security-fix-typos -> nodejs:main Labels doc, fast-track, author ready Commits 1 - doc: fix typos in SECURITY.md Committers 1 - Mohammed Keyvanzadeh PR-URL: https://github.com/nodejs/node/pull/47677 Reviewed-By: Daeyeon Jeong Reviewed-By: Deokjin Kim Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47677 Reviewed-By: Daeyeon Jeong Reviewed-By: Deokjin Kim Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 22 Apr 2023 22:56:31 GMT ✔ Approvals: 3 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/47677#pullrequestreview-1396829986 ✔ - Deokjin Kim (@deokjinkim): https://github.com/nodejs/node/pull/47677#pullrequestreview-1396836580 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47677#pullrequestreview-1396838353 ℹ This PR is being fast-tracked ✘ This PR needs to wait 41 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4776630108 |
MoLow
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Apr 23, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 23, 2023
Landed in a6748ec |
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47677 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47677 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 29, 2023
PR-URL: nodejs#47677 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47677 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47677 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47677 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.