-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typos #47685
Merged
Merged
doc: fix typos #47685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
We generally use American English in the documentation so changes like |
targos
approved these changes
Apr 23, 2023
debadree25
approved these changes
Apr 23, 2023
debadree25
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Apr 23, 2023
daeyeon
approved these changes
Apr 23, 2023
VoltrexKeyva
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Apr 23, 2023
Fast-track has been requested by @VoltrexKeyva. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Apr 23, 2023
Commit Queue failed- Loading data for nodejs/node/pull/47685 ✔ Done loading data for nodejs/node/pull/47685 ----------------------------------- PR info ------------------------------------ Title doc: fix typos (#47685) Author Mohammed Keyvanzadeh (@VoltrexKeyva) Branch VoltrexKeyva:fix-typos -> nodejs:main Labels doc, fast-track, author ready Commits 1 - doc: fix typos Committers 1 - Mohammed Keyvanzadeh PR-URL: https://github.com/nodejs/node/pull/47685 Reviewed-By: Michaël Zasso Reviewed-By: Debadree Chatterjee Reviewed-By: Daeyeon Jeong ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47685 Reviewed-By: Michaël Zasso Reviewed-By: Debadree Chatterjee Reviewed-By: Daeyeon Jeong -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 23 Apr 2023 09:53:26 GMT ✔ Approvals: 3 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47685#pullrequestreview-1396882238 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/47685#pullrequestreview-1396894122 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/47685#pullrequestreview-1396906197 ℹ This PR is being fast-tracked ✘ This PR needs to wait 44 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4778585088 |
aduh95
added
commit-queue
Add this label to land a pull request using GitHub Actions.
and removed
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
labels
Apr 23, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 23, 2023
Landed in 32e478d |
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 29, 2023
PR-URL: nodejs#47685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47685 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.