Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix creating an ArrayBuffer from a Blob created with openAsBlob #47691

Closed
wants to merge 1 commit into from
Closed

src: fix creating an ArrayBuffer from a Blob created with openAsBlob #47691

wants to merge 1 commit into from

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Apr 24, 2023

Fixes: #47683

This fixes creating an ArrayBuffer from a Blob sliced from a Blob created with fs.openAsBlob.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 24, 2023
@daeyeon daeyeon marked this pull request as draft April 24, 2023 05:54
@daeyeon daeyeon force-pushed the main.fix/47683-230424.Mon.d73a branch from 2b97826 to babd5a0 Compare April 24, 2023 06:03
@daeyeon daeyeon marked this pull request as ready for review April 24, 2023 06:15
@ikreymer
Copy link

Thanks! Assume the fix should also apply to .stream() - the issue manifested in both .arrayBuffer() and .stream() but reported for arrayBuffer() as that was simpler repro, but perhaps worth adding a test for stream as well?

@daeyeon
src: fix creating an ArrayBuffer from a Blob created with openAsBlob
6e40de0 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@daeyeon daeyeon force-pushed the main.fix/47683-230424.Mon.d73a branch from babd5a0 to 6e40de0 Compare April 25, 2023 03:00
@daeyeon
Copy link
Member Author

daeyeon commented Apr 25, 2023

@ikreymer That would be better. Updated the test for stream also, PTAL.

@ikreymer
Copy link

@ikreymer That would be better. Updated the test for stream also, PTAL.

Yes, that looks good - thanks!

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Open
35 tasks
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51501/

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2023
This was referenced Apr 28, 2023
Open
Open
Open
Open
Open
Open
jasnell pushed a commit that referenced this pull request May 5, 2023
@daeyeon @jasnell
src: fix creating an ArrayBuffer from a Blob created with openAsBlob
af9b48a 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #47691
Fixes: #47683
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 5, 2023

Landed in af9b48a

@jasnell jasnell closed this May 5, 2023
@daeyeon daeyeon deleted the main.fix/47683-230424.Mon.d73a branch May 5, 2023 02:18
targos pushed a commit that referenced this pull request May 12, 2023
@daeyeon @targos
src: fix creating an ArrayBuffer from a Blob created with openAsBlob
c421761 
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #47691
Fixes: #47683
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slice on blob created with fs.openAsBlob results in incorrect length (end + start instead of end - start?)
5 participants
@daeyeon @ikreymer @nodejs-github-bot @jasnell @danielleadams