doc: mark signing the binary is macOS and Windows only in single-executable docs #47722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
meixg
force-pushed
the
single-executable
branch
from
87f210d to
b689324
Compare
meixg
force-pushed
the
single-executable
branch
from
b689324 to
1e7b49a
Compare
RaisinTen
approved these changes
Apr 26, 2023
RaisinTen
added
author ready
aymen94
approved these changes
Apr 26, 2023
VoltrexKeyva
approved these changes
Apr 26, 2023
ovflowd
approved these changes
Apr 26, 2023
Ayase-252
approved these changes
Apr 28, 2023
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a75959b |
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 29, 2023
PR-URL: nodejs#47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
danielleadams
added
the
backport-blocked-v18.x
|
Blocked by #47125 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a little confusing for Linux users at steps about signing the binary right now.