Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace idna functions with ada::idna #47735

Merged
merged 1 commit into from
Apr 28, 2023
Merged

src: replace idna functions with ada::idna #47735

merged 1 commit into from
Apr 28, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 26, 2023 •
edited
Loading

Fixes #47726

Co-authored-by: Daniel Lemire (@lemire)

cc @tniessen @nodejs/cpp-reviewers @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 26, 2023
@tniessen tniessen added the blocked PRs that are blocked by other issues or PRs. label Apr 26, 2023
jasnell
jasnell reviewed Apr 26, 2023
View reviewed changes
src/encoding_binding.cc Outdated Show resolved Hide resolved
@anonrig @lemire
src: replace idna functions with ada::idna
6f50d09 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Apr 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51510/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51511/

@github-actions github-actions bot mentioned this pull request Apr 28, 2023
Open
29 tasks
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2023
TimothyGu
TimothyGu reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add a comment in the code how these are different from the existing domainToASCII/Unicode functions. Additionally, this PR needs tests. Oh right it fixes existing tests.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1123377 into main Apr 28, 2023
@nodejs-github-bot nodejs-github-bot deleted the fix-idna-js branch April 28, 2023 18:48
@nodejs-github-bot
Copy link
Collaborator

Landed in 1123377

@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Open
32 tasks
yjl9903 pushed a commit to yjl9903/node that referenced this pull request Apr 29, 2023
@anonrig @lemire @yjl9903
src: replace idna functions with ada::idna
b2593f0 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: nodejs#47735
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Apr 30, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig @lemire @targos
src: replace idna functions with ada::idna
f857ff3 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: #47735
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request May 3, 2023
Open
33 tasks
targos pushed a commit that referenced this pull request May 3, 2023
@anonrig @lemire @targos
src: replace idna functions with ada::idna
dc43ce7 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: #47735
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@danielleadams danielleadams added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Jul 4, 2023
@anonrig anonrig mentioned this pull request Jul 21, 2023
Closed
anonrig added a commit to anonrig/node that referenced this pull request Jul 21, 2023
@anonrig @lemire
src: replace idna functions with ada::idna
17649f7 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: nodejs#47735
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
This was referenced Jul 21, 2023
Closed
Closed
anonrig added a commit to anonrig/node that referenced this pull request Jul 22, 2023
@anonrig @lemire
src: replace idna functions with ada::idna
6c602b3 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: nodejs#47735
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 16, 2023
@anonrig @lemire @ruyadorno
src: replace idna functions with ada::idna
e426180 
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: #47735
Backport-PR-URL: #48873
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@ruyadorno ruyadorno added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Aug 16, 2023
@ruyadorno ruyadorno mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu left review comments

@lemire lemire lemire left review comments

@JungMinu JungMinu JungMinu approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test-dns-ipv6.js is broken
9 participants
@anonrig @nodejs-github-bot @lemire @jasnell @TimothyGu @JungMinu @ruyadorno @tniessen @danielleadams