Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webstreams.md #47762

Closed
wants to merge 1 commit into from
Closed

Update webstreams.md #47762

wants to merge 1 commit into from

Conversation

christiantakle
Copy link
Contributor

@christiantakle christiantakle commented Apr 28, 2023 •
edited
Loading

doc: fix arrayBuffer alias typo

buffer was aliased to arrayBuffer in an example for arrayBuffer.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 28, 2023
debadree25
debadree25 approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@debadree25 debadree25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
could you just update your commit message according to the guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Thanks!

@christiantakle
Copy link
Contributor Author

Haha knew something like this would happen.

git clone git@github.com:christiantakle/node.git --depth=1 --branch=patch-1
# rename commit with lazygit
git push --force-with-lease

Meh will have to recreate.

@debadree25
Copy link
Member

ah i think git push -f would have been fine somehow --force-with-lease closes the PR I think? interesting

@christiantakle
Copy link
Contributor Author

Interesting indeed :D

@christiantakle
Copy link
Contributor Author

christiantakle commented Apr 28, 2023 •
edited
Loading

Cloned pr #47766

@christiantakle christiantakle mentioned this pull request Apr 28, 2023
Merged
@christiantakle christiantakle deleted the patch-1 branch April 28, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christiantakle @debadree25 @nodejs-github-bot