doc: fix, remove unnecessary bind(this) #4797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might as well make it an expression (single-line) arrow function |
|
LGTM. |
|
I think will need to refactor all other arrow functions, If make it as a single-line expression, for uniform code style. |
mscdex
added
doc
|
I think usually keeping the braces will help understandability in docs for newcomers. cc @nodejs/documentation |
|
+1 to keeping the braces |
|
Also +1 to keeping braces. LGTM as is. |
|
LGTM. The brace/no-brace disagreement emphasizes the degree to which we need to put a linter in the doctool. |
|
Related nodejs/docs#62 |
silverwind
pushed a commit
that referenced
this pull request
Jan 26, 2016
PR-URL: #4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Thanks! Landed in 2c42635. |
rvagg
pushed a commit
that referenced
this pull request
Jan 27, 2016
PR-URL: #4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
benjamingr
pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
PR-URL: nodejs#4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
PR-URL: #4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4797 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chris Dickinson <chris@neversaw.us> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.