docs: add scp examples to release.md #4808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the release steps mention using scp to upload and download SHASUMS256.txt This commit adds easy to follow examples of using scp for reference. PR-URL: nodejs#4808 Reviewed-By:
MylesBorins
force-pushed
the
scp-examples
branch
from
6e0c632
to
8054f7e
Compare
MylesBorins
added
doc
|
LGTM |
|
hm, I'm -0 on this, that section is intended to tell you what release.sh does, not give you steps to follow to do it manually, that shouldn't be done at all and I'd rather not encourage folks to do that ever |
|
Ohhhh. Then I think the copy should be changed, as it was not obvious that
those steps were automatically done by the script. I thought those were
manual steps.
|
|
Closing |
|
I just re read the steps again, and I think the current copy is fairly obvious. I think I was being a bit to pedantic going through all the steps on the first run through and managed to misunderstand. Thanks for taking the time to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the release steps mention using scp to upload and download
SHASUMS256.txt
This commit adds easy to follow examples of using scp for reference.