tools: add version to maintaining-dependencies.md dependencies list and automate the update #48081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tniessen
reviewed
May 20, 2023
|
@tniessen I'm agree with you. I started recently to collaborate on node and I wasn't sure if I could (or not) create new files. Anyway if this refactor is ok, than I can continue with the other dependencies. |
RaisinTen
reviewed
May 21, 2023
|
why do you say they dont commit any change? The commit is done in the action that triggers all these scripts: node/.github/workflows/tools.yml Line 295 in 959142a the version of undici is currently 5.22.1 https://github.com/nodejs/node/blob/main/deps/undici/src/package.jsonyou can update it with NEW_VERSION https://github.com/nodejs/node/blob/main/tools/dep_updaters/update-undici.shFor zlib we might want to use latest version + commit hash. For v8 we have automated only patch update so if it's a major update it has to be done manually. postject should be like every other dependency |
fasenderos
force-pushed
the
deps-version
branch
2 times, most recently
from
7bf0db3
to
ce7111a
Compare
|
@marco-ippolito I have added version to |
|
pr for histogram dep_updater : #48171 landed |
fasenderos
force-pushed
the
deps-version
branch
3 times, most recently
from
af728dd
to
86e0c9d
Compare
9 tasks
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file
|
@marco-ippolito added version for |
targos
reviewed
May 31, 2023
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c541153 |
3 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: #48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: nodejs#48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Refs: nodejs/security-wg#973 Most of the duplicated code in all the dependencies updaters has been moved in the `utils.sh` file PR-URL: nodejs#48081 Refs: nodejs/security-wg#973 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
ruyadorno
added
the
backport-requested-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version to
doc/contributing/maintaining/maintaining-dependencies.mddependencies list and automate the updateRefs: nodejs/security-wg#973
Most of the duplicated code in all the dependencies updaters has been moved in the
utils.shfileThis is the list of all the dependencies: