Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update socket.remote* properties documentation #48139

Merged
merged 1 commit into from
May 25, 2023
Merged

doc: update socket.remote* properties documentation #48139

merged 1 commit into from
May 25, 2023

Conversation

Basa198
Copy link
Contributor

@Basa198 Basa198 commented May 23, 2023

Fixes: #48061

Just added in that socket.remoteFamily and socket.remotePort may be undefined as well if the socket is destroyed.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels May 23, 2023
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5275843 into nodejs:main May 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 5275843

@Basa198 Basa198 deleted the docs.remote.status branch May 25, 2023 14:23
@Basa198 Basa198 restored the docs.remote.status branch May 25, 2023 14:23
@Basa198 Basa198 deleted the docs.remote.status branch May 25, 2023 14:23
@Basa198 Basa198 restored the docs.remote.status branch May 25, 2023 14:23
@Basa198 Basa198 deleted the docs.remote.status branch May 25, 2023 14:29
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request May 26, 2023
@Basa198 @marco-ippolito
doc: update socket.remote* properties documentation
8c9242d 
Fixes: nodejs#48061
PR-URL: nodejs#48139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2023
@Basa198 @targos
doc: update socket.remote* properties documentation
39d8140 
Fixes: #48061
PR-URL: #48139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@Basa198 @danielleadams
doc: update socket.remote* properties documentation
cc2d675 
Fixes: #48061
PR-URL: #48139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@Basa198 @MoLow
doc: update socket.remote* properties documentation
69205a2 
Fixes: nodejs#48061
PR-URL: nodejs#48139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Basa198 @Ceres6
doc: update socket.remote* properties documentation
e43f28f 
Fixes: nodejs#48061
PR-URL: nodejs#48139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@Basa198 @Ceres6
doc: update socket.remote* properties documentation
d8f2e5d 
Fixes: nodejs#48061
PR-URL: nodejs#48139
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymen94 aymen94 aymen94 approved these changes

@Trott Trott Trott approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closed socket leads to undefined values in socket.remote* properties
6 participants
@Basa198 @nodejs-github-bot @ShogunPanda @bnoordhuis @Trott @aymen94