Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: refactor redeclared variables #4816

Closed
wants to merge 1 commit into from
Closed

stream: refactor redeclared variables #4816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/_stream_readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ function readableAddChunk(stream, state, chunk, encoding, addToFront) {
onEofChunk(stream, state);
} else if (state.objectMode || chunk && chunk.length > 0) {
if (state.ended && !addToFront) {
var e = new Error('stream.push() after EOF');
const e = new Error('stream.push() after EOF');
stream.emit('error', e);
} else if (state.endEmitted && addToFront) {
var e = new Error('stream.unshift() after end event');
const e = new Error('stream.unshift() after end event');
stream.emit('error', e);
} else {
if (state.decoder && !addToFront && !encoding)
Expand Down Expand Up @@ -640,13 +640,13 @@ Readable.prototype.unpipe = function(dest) {
state.pipesCount = 0;
state.flowing = false;

for (var i = 0; i < len; i++)
for (let i = 0; i < len; i++)
dests[i].emit('unpipe', this);
return this;
}

// try to find the right one.
var i = state.pipes.indexOf(dest);
const i = state.pipes.indexOf(dest);
if (i === -1)
return this;

Expand Down Expand Up @@ -847,7 +847,7 @@ function fromList(n, state) {
if (n < list[0].length) {
// just take a part of the first list item.
// slice is the same for buffers and strings.
var buf = list[0];
const buf = list[0];
ret = buf.slice(0, n);
list[0] = buf.slice(n);
} else if (n === list[0].length) {
Expand All @@ -863,7 +863,7 @@ function fromList(n, state) {

var c = 0;
for (var i = 0, l = list.length; i < l && c < n; i++) {
var buf = list[0];
const buf = list[0];
var cpy = Math.min(n - c, buf.length);

if (stringMode)
Expand Down