Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix output message when repl is used with pm #48438

Merged
merged 1 commit into from
Jun 17, 2023
Merged

lib: fix output message when repl is used with pm #48438

merged 1 commit into from
Jun 17, 2023

Conversation

RafaelGSS
Copy link
Member

We use FileSytemWrite and FileSytemRead now.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jun 12, 2023
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@RafaelGSS
Copy link
Member Author

cc: @nodejs/security-wg

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52237/

@RafaelGSS RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit ff14b24 into nodejs:main Jun 17, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in ff14b24

RafaelGSS added a commit that referenced this pull request Jul 3, 2023
@RafaelGSS
lib: fix output message when repl is used with pm
fe16749 
PR-URL: #48438
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
lib: fix output message when repl is used with pm
580a5ef 
PR-URL: nodejs#48438
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@RafaelGSS @Ceres6
lib: fix output message when repl is used with pm
3de520e 
PR-URL: nodejs#48438
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadorno ruyadorno added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Sep 8, 2023
@ruyadorno
Copy link
Member

@RafaelGSS it looks like to me this message is not really in v18, please feel free to correct me if I'm wrong.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Sep 19, 2023
@RafaelGSS
Copy link
Member Author

Yes, that's correct @ruyadorno. Sorry about that. All the PRs targeting permission must not land in v18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafaelGSS @nodejs-github-bot @ruyadorno @lpinca @tniessen