New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

permission: add debug log when inserting fs nodes #48677

Merged

nodejs-github-bot merged 1 commit into nodejs:main from RafaelGSS:debug-pm

Jul 13, 2023

Member

RafaelGSS commented Jul 6, 2023

This will help when debugging issues in the filesystem Radix tree.

Output example:

$ NODE_DEBUG_NATIVE=PERMISSION_MODEL ./node --experimental-permission --allow-fs-read=/tmp/,/home/,/host -p '1 + 1'
Inserting /tmp/*
 Prefix:
 Child(1): /
   Wildcard: /tmp/*
 End of tree - child(1)
Inserting /home/*
 Prefix:
 Child(1): /
   Prefix: /
   Child(1): h
     Wildcard: home/*
   Child(2): t
     Wildcard: tmp/*
   End of tree - child(2)
 End of tree - child(1)
Inserting /host
 Prefix:
 Child(1): /
   Prefix: /
   Child(1): h
     Prefix: ho
     Child(1): s
       Prefix: st
       End of tree: st
     Child(2): m
       Wildcard: me/*
     End of tree - child(2)
   Child(2): t
     Wildcard: tmp/*
   End of tree - child(2)
 End of tree - child(1)
2
(node:999070) ExperimentalWarning: Permission is an experimental feature
(Use `node --trace-warnings ...` to show where the warning was created)

cc: @nodejs/security-wg

Collaborator

nodejs-github-bot commented Jul 6, 2023

Review requested:

@nodejs/security-wg

nodejs-github-bot added c++ debugger needs-ci labels


          permission: add debug log when inserting fs nodes

b04f34c

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

RafaelGSS force-pushed the debug-pm branch from 2697264 to b04f34c Compare

July 6, 2023 13:17

ShogunPanda approved these changes

View reviewed changes

RafaelGSS added the request-ci label

github-actions bot removed the request-ci label

Collaborator

nodejs-github-bot commented Jul 7, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/52647/

RafaelGSS added the commit-queue label

nodejs-github-bot removed the commit-queue label

nodejs-github-bot merged commit 8efdc7d into nodejs:main

Collaborator

nodejs-github-bot commented Jul 13, 2023

Landed in 8efdc7d

juanarbol pushed a commit that referenced this pull request


          permission: add debug log when inserting fs nodes

82d6b13

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #48677
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

juanarbol mentioned this pull request

V20.5.0 proposal #48761

Merged

tniessen added a commit to tniessen/node that referenced this pull request


          permission: fix data types in PrintTree

024af08

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: nodejs#48677

tniessen mentioned this pull request

permission: fix data types in PrintTree #48770

Merged

nodejs-github-bot pushed a commit that referenced this pull request


          permission: fix data types in PrintTree

1d1a85b

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: #48677
PR-URL: #48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

tniessen added the permission label

Ceres6 pushed a commit to Ceres6/node that referenced this pull request


          permission: add debug log when inserting fs nodes

24bba8b

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#48677
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request


          permission: fix data types in PrintTree

6d53d0e

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: nodejs#48677
PR-URL: nodejs#48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request


          permission: add debug log when inserting fs nodes

05d58d2

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#48677
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

Ceres6 pushed a commit to Ceres6/node that referenced this pull request


          permission: fix data types in PrintTree

1f69b61

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: nodejs#48677
PR-URL: nodejs#48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request


          permission: fix data types in PrintTree

0d48ac8

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: nodejs#48677
PR-URL: nodejs#48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

RafaelGSS pushed a commit that referenced this pull request


          permission: fix data types in PrintTree

30ea480

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: #48677
PR-URL: #48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ruyadorno pushed a commit that referenced this pull request


          permission: add debug log when inserting fs nodes

8cab61c

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #48677
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

ruyadorno pushed a commit that referenced this pull request


          permission: fix data types in PrintTree

0eb0748

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: #48677
PR-URL: #48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ruyadorno pushed a commit that referenced this pull request


          permission: add debug log when inserting fs nodes

07eac0d

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #48677
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

ruyadorno pushed a commit that referenced this pull request


          permission: fix data types in PrintTree

817b59c

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: #48677
PR-URL: #48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ruyadorno mentioned this pull request

v18.18.0 proposal #49220

Merged

ruyadorno pushed a commit that referenced this pull request


          permission: add debug log when inserting fs nodes

7aaecce

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #48677
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

ruyadorno pushed a commit that referenced this pull request


          permission: fix data types in PrintTree

804d880

* The first argument `node` should be a const pointer.
* The second argument `spaces` should not be a signed integer type.
* The local variable `child` should be size_t.
* The local variable `pair` in the range declaration should be a
  reference type to avoid copying the object.

Refs: #48677
PR-URL: #48770
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ debugger needs-ci permission