Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: V8: cherry-pick c1a54d5ffcd1 #48830

Closed
wants to merge 2 commits into from
Closed

deps: V8: cherry-pick c1a54d5ffcd1 #48830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e76f125
deps: V8: cherry-pick c1a54d5ffcd1
joyeecheung Jul 18, 2023
984af04
deps: V8: cherry-pick 9f4b7699f68e
joyeecheung Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.13',

##### V8 defaults for Node.js #####

Expand Down
22 changes: 17 additions & 5 deletions deps/v8/test/mjsunit/regress/regress-1320641.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,21 @@ function foo(){
const xs = new Uint16Array(3775336418);
return xs[-981886074];
}
%PrepareFunctionForOptimization(foo);
foo();

assertEquals(undefined, foo());
%OptimizeFunctionOnNextCall(foo);
assertEquals(undefined, foo());
var skip = false;
try {
new Uint16Array(3775336418);
} catch (e) {
if (/Array buffer allocation failed/.test(e.message)) {
skip = true; // We don't have enough memory, just skip the test.
}
}

if (!skip) {
%PrepareFunctionForOptimization(foo);
foo();

assertEquals(undefined, foo());
%OptimizeFunctionOnNextCall(foo);
assertEquals(undefined, foo());
}