doc: improved joinDuplicateHeaders definition #48859

OnSuorce · 2023-07-20T20:06:42Z

Improved documentation for joinDuplicateHeaders definition

nodejs-github-bot · 2023-07-20T20:06:47Z

Review requested:

@nodejs/http
@nodejs/net

mcollina

lgtm

nodejs-github-bot · 2023-07-21T08:25:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/52883/

doc/api/http.md

lpinca · 2023-07-21T14:03:09Z

s/improved/improve/ in commit message.

…suggestion Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot · 2023-07-28T09:58:54Z

Commit Queue failed

- Loading data for nodejs/node/pull/48859
✔  Done loading data for nodejs/node/pull/48859
----------------------------------- PR info ------------------------------------
Title      doc: improved joinDuplicateHeaders definition (#48859)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     OnSuorce:pippo_pluto_paperino -> nodejs:main
Labels     http, doc
Commits    2
 - doc: improved joinDuplicateHeaders definition
 - doc: Improved documentation for joinDuplicateHeaders definition with …
Committers 2
 - Matteo Bianchi 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/48859
Reviewed-By: Paolo Insogna 
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/48859
Reviewed-By: Paolo Insogna 
Reviewed-By: Matteo Collina 
Reviewed-By: Marco Ippolito 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: Improved documentation for joinDuplicateHeaders definition with …
   ℹ  This PR was created on Thu, 20 Jul 2023 20:06:42 GMT
   ✔  Approvals: 4
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540666443
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540704845
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540708447
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48859#pullrequestreview-1541219659
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/5690667896

mcollina

lgtm

nodejs-github-bot · 2023-07-28T10:10:29Z

Commit Queue failed

- Loading data for nodejs/node/pull/48859 ✔ Done loading data for nodejs/node/pull/48859 ----------------------------------- PR info ------------------------------------ Title doc: improved joinDuplicateHeaders definition (#48859) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch OnSuorce:pippo_pluto_paperino -> nodejs:main Labels http, doc Commits 2 - doc: improved joinDuplicateHeaders definition - doc: Improved documentation for joinDuplicateHeaders definition with … Committers 2 - Matteo Bianchi - GitHub PR-URL: https://github.com/nodejs/node/pull/48859 Reviewed-By: Paolo Insogna Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48859 Reviewed-By: Paolo Insogna Reviewed-By: Matteo Collina Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 20 Jul 2023 20:06:42 GMT ✔ Approvals: 4 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540666443 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/48859#pullrequestreview-1551772240 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/48859#pullrequestreview-1540708447 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48859#pullrequestreview-1541219659 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 48859 From https://github.com/nodejs/node * branch refs/pull/48859/merge -> FETCH_HEAD ✔ Fetched commits as 48345d0f6212..6fd16accaa00 -------------------------------------------------------------------------------- Auto-merging doc/api/http.md [main decba93713] doc: improved joinDuplicateHeaders definition Author: Matteo Bianchi Date: Thu Jul 20 22:04:35 2023 +0200 1 file changed, 5 insertions(+), 4 deletions(-) Auto-merging doc/api/http.md [main 739d49b1cb] doc: Improved documentation for joinDuplicateHeaders definition with suggestion Author: Matteo Bianchi <47943069+OnSuorce@users.noreply.github.com> Date: Wed Jul 26 00:11:53 2023 +0200 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: improved joinDuplicateHeaders definition

PR-URL: #48859
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD d838984e02] doc: improved joinDuplicateHeaders definition
Author: Matteo Bianchi bianchi.57.matteo@gmail.com
Date: Thu Jul 20 22:04:35 2023 +0200
1 file changed, 5 insertions(+), 4 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: Improved documentation for joinDuplicateHeaders definition with suggestion

Co-authored-by: Luigi Pinca luigipinca@gmail.com
PR-URL: #48859
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 2086d3ed8c] doc: Improved documentation for joinDuplicateHeaders definition with suggestion
Author: Matteo Bianchi 47943069+OnSuorce@users.noreply.github.com
Date: Wed Jul 26 00:11:53 2023 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/5690765380

nodejs-github-bot · 2023-07-28T10:47:31Z

Landed in 8f0f17e

PR-URL: nodejs#48859 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #48859 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

doc: improved joinDuplicateHeaders definition

d0ca2a2

nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jul 20, 2023

ShogunPanda approved these changes Jul 21, 2023

View reviewed changes

mcollina approved these changes Jul 21, 2023

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023

marco-ippolito approved these changes Jul 21, 2023

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2023

lpinca approved these changes Jul 21, 2023

View reviewed changes

doc/api/http.md Outdated Show resolved Hide resolved

This was referenced Jul 22, 2023

CI Reliability 2023-07-22 nodejs/reliability#620

Open

CI Reliability 2023-07-23 nodejs/reliability#621

Open

CI Reliability 2023-07-24 nodejs/reliability#622

Open

CI Reliability 2023-07-25 nodejs/reliability#623

Open

aymen94 approved these changes Jul 25, 2023

View reviewed changes

doc: Improved documentation for joinDuplicateHeaders definition with …

6fd16ac

…suggestion Co-authored-by: Luigi Pinca <luigipinca@gmail.com>

This was referenced Jul 26, 2023

CI Reliability 2023-07-26 nodejs/reliability#624

Open

CI Reliability 2023-07-27 nodejs/reliability#625

Open

CI Reliability 2023-07-28 nodejs/reliability#626

Open

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 28, 2023

mcollina approved these changes Jul 28, 2023

View reviewed changes

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 28, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 28, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 28, 2023

nodejs-github-bot merged commit 8f0f17e into nodejs:main Jul 28, 2023
32 checks passed

github-actions bot mentioned this pull request Jul 29, 2023

CI Reliability 2023-07-29 nodejs/reliability#627

Open

23 tasks

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: improved joinDuplicateHeaders definition #48859

doc: improved joinDuplicateHeaders definition #48859

OnSuorce commented Jul 20, 2023

nodejs-github-bot commented Jul 20, 2023

mcollina left a comment

nodejs-github-bot commented Jul 21, 2023

lpinca commented Jul 21, 2023

nodejs-github-bot commented Jul 28, 2023

mcollina left a comment

nodejs-github-bot commented Jul 28, 2023

PR-URL: #48859
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

Co-authored-by: Luigi Pinca luigipinca@gmail.com
PR-URL: #48859
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jul 28, 2023

doc: improved joinDuplicateHeaders definition #48859

doc: improved joinDuplicateHeaders definition #48859

Conversation

OnSuorce commented Jul 20, 2023

nodejs-github-bot commented Jul 20, 2023

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 21, 2023

lpinca commented Jul 21, 2023

nodejs-github-bot commented Jul 28, 2023

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 28, 2023

PR-URL: #48859 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Marco Ippolito marcoippolito54@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

Co-authored-by: Luigi Pinca luigipinca@gmail.com PR-URL: #48859 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Marco Ippolito marcoippolito54@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Jul 28, 2023

PR-URL: #48859
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

Co-authored-by: Luigi Pinca luigipinca@gmail.com
PR-URL: #48859
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com