gyp: put cctest filenames in variables #49178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
targos
approved these changes
Aug 15, 2023
gengjiawen
approved these changes
Aug 15, 2023
joyeecheung
approved these changes
Aug 15, 2023
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Aug 15, 2023
32 tasks
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Aug 21, 2023
21 tasks
This was referenced Aug 23, 2023
Qard
approved these changes
Sep 8, 2023
Qard
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3163f8d |
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49178 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49178 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #46965, which will be very helpful for #47637.