sea: generate code cache with deserialized isolate #49226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
|
(Also, just realized that we didn't actually have to create an entire environment to compile the built-in code cache, since we don't need the context snapshot, just the isolate one..) |
joyeecheung
force-pushed
the
sea-code-cache
branch
from
527718e to
7ad8cfb
Compare
RaisinTen
approved these changes
Aug 18, 2023
RaisinTen
reviewed
Aug 18, 2023
joyeecheung
added
request-ci
V8 now requires code cache to be compiled from an isolate with the same RO space layout as the one that's going to deserialize the cache, so for a binary built with snapshot, we need to compile the code cache using a deserialized isolate. Drive-by: ignore "useCodeCache" when "useSnapshot" is true because the compilation would've been done during build time anyway in that case, and print a warning for it.
joyeecheung
force-pushed
the
sea-code-cache
branch
from
ddeb039 to
661edfe
Compare
github-actions
bot
removed
the
request-ci
RaisinTen
approved these changes
Aug 18, 2023
anonrig
approved these changes
Aug 19, 2023
anonrig
added
the
author ready
35 tasks
21 tasks
aymen94
approved these changes
Aug 22, 2023
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 62b2cf3...5c9daf4 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
PR-URL: #49226 Refs: nodejs/node-v8#252 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 22, 2023
V8 now requires code cache to be compiled from an isolate with the same RO space layout as the one that's going to deserialize the cache, so for a binary built with snapshot, we need to compile the code cache using a deserialized isolate. Drive-by: ignore "useCodeCache" when "useSnapshot" is true because the compilation would've been done during build time anyway in that case, and print a warning for it. PR-URL: #49226 Refs: nodejs/node-v8#252 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Aug 23, 2023
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
PR-URL: #49226 Refs: nodejs/node-v8#252 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Sep 10, 2023
V8 now requires code cache to be compiled from an isolate with the same RO space layout as the one that's going to deserialize the cache, so for a binary built with snapshot, we need to compile the code cache using a deserialized isolate. Drive-by: ignore "useCodeCache" when "useSnapshot" is true because the compilation would've been done during build time anyway in that case, and print a warning for it. PR-URL: #49226 Refs: nodejs/node-v8#252 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 now requires code cache to be compiled from an isolate with the same RO space layout as the one that's going to deserialize the cache, so for a binary built with snapshot, we need to compile the code cache using a deserialized isolate.
Drive-by: ignore "useCodeCache" when "useSnapshot" is true because the compilation would've been done during build time anyway in that case, and print a warning for it.
Refs: nodejs/node-v8#252