-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add DEBUG_ONLY to Makefile to support debug-only builds #49229
base: main
Are you sure you want to change the base?
Conversation
Previously, when setting BUILDTYPE=Debug, `make` would build both the release build and the debug build and use the release build to run certain build steps before running the tests using the debug build. This patch adds another DEBUG_ONLY switch to the Makefile. When it's used in conjunction with BUILDTYPE=Debug Node.js no longer builds the release build and instead would just use the debug build to complete the build steps. ``` DEBUG_ONLY=1 BUILDTYPE=Debug BUILD_WITH=ninja make test-only ```
Draft for now, I've only tested it with the ninja builds, not the make builds |
Not that I have a super strong opinion but... I just |
The point is not just building debug builds, but also running all the tests with just the debug builds i.e. after running |
Previously, when setting BUILDTYPE=Debug,
make
would build boththe release build and the debug build and use the release build
to run certain build steps before running the tests using the
debug build. This patch adds another DEBUG_ONLY switch to the
Makefile. When it's used in conjunction with BUILDTYPE=Debug
Node.js no longer builds the release build and instead would
just use the debug build to complete the build steps.