Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add assertion for TLS peer certificate fingerprint #4923

Closed
wants to merge 1 commit into from
Closed

test: Add assertion for TLS peer certificate fingerprint #4923

wants to merge 1 commit into from

Conversation

alandotcom
Copy link

PR-URL: #4923
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

@mscdex mscdex added tls Issues and PRs related to the tls subsystem. test Issues and PRs related to the tests. labels Jan 28, 2016
@bnoordhuis
Copy link
Member

LGTM but can you amend the commit log so it conforms to the guidelines from CONTRIBUTING.md? In particular, it should start with the subsystem (test:).

CI: https://ci.nodejs.org/job/node-test-pull-request/1419/ (currently private because of the upcoming security release.)

@alandotcom alandotcom changed the title Add assertion for TLS peer certificate fingerprint test: Add assertion for TLS peer certificate fingerprint Jan 29, 2016
@alandotcom
Copy link
Author

Thanks @bnoordhuis. Just updated the commit message

@jasnell
Copy link
Member

jasnell commented Jan 29, 2016

LGTM

@bnoordhuis
Copy link
Member

@LumberJ Can you run make lint? The linter is complaining that:

/usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-tls-peer-certificate.js
  41:1  error  Line 41 exceeds the maximum line length of 80  max-len

test: Add assertion for TLS peer certificate fingerprint
7b61f02 
PR-URL: nodejs#4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@alandotcom
Copy link
Author

Thanks, just fixed the lint error.

On Fri, Jan 29, 2016 at 12:36 AM, Ben Noordhuis notifications@github.com
wrote:

@LumberJ https://github.com/lumberj Can you run make lint? The linter
is complaining that:

/usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-tls-peer-certificate.js
41:1 error Line 41 exceeds the maximum line length of 80 max-len

—
Reply to this email directly or view it on GitHub
#4923 (comment).

Alan Cohen
@alan_mit https://twitter.com/intent/user?screen_name=alan_mit

jasnell pushed a commit that referenced this pull request Feb 1, 2016
@jasnell
test: Add assertion for TLS peer certificate fingerprint
59fb26c 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 1, 2016

Landed in 59fb26c

@jasnell jasnell closed this Feb 1, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
@rvagg
test: Add assertion for TLS peer certificate fingerprint
0384a43 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rvagg rvagg mentioned this pull request Feb 8, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Feb 17, 2016
test: Add assertion for TLS peer certificate fingerprint
6afd2a4 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 18, 2016
test: Add assertion for TLS peer certificate fingerprint
f5d29d7 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 18, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
test: Add assertion for TLS peer certificate fingerprint
674415b 
PR-URL: #4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
test: Add assertion for TLS peer certificate fingerprint
7af2c6e 
PR-URL: nodejs#4923
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alandotcom @bnoordhuis @jasnell @mscdex @MylesBorins