Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add missing thread-common.c in uv.gyp #49410

Merged
merged 1 commit into from
Sep 1, 2023
Merged

deps: add missing thread-common.c in uv.gyp #49410

merged 1 commit into from
Sep 1, 2023

Conversation

santigimeno
Copy link
Member

This should fix #49409

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Aug 30, 2023
@santigimeno santigimeno mentioned this pull request Aug 30, 2023
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53643/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 30, 2023
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2023
@nodejs-github-bot nodejs-github-bot merged commit df16705 into nodejs:main Sep 1, 2023
3 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in df16705

arsnyder16 pushed a commit to arsnyder16/node that referenced this pull request Sep 10, 2023
@santigimeno @arsnyder16
deps: add missing thread-common.c in uv.gyp
b46620a 
PR-URL: nodejs#49410
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@arsnyder16 arsnyder16 mentioned this pull request Sep 10, 2023
Closed
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@santigimeno @UlisesGascon
deps: add missing thread-common.c in uv.gyp
84195d9 
PR-URL: #49410
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 11, 2023
@santigimeno @ruyadorno
deps: add missing thread-common.c in uv.gyp
7b72655 
PR-URL: #49410
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #48078
@ruyadorno ruyadorno added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Sep 11, 2023
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
@santigimeno @ruyadorno
deps: add missing thread-common.c in uv.gyp
34a9a3c 
PR-URL: #49410
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #48078
ruyadorno pushed a commit that referenced this pull request Sep 17, 2023
@santigimeno @ruyadorno
deps: add missing thread-common.c in uv.gyp
ea23870 
PR-URL: #49410
Backport-PR-URL: #49591
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #48078
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@santigimeno @alexfernandez
deps: add missing thread-common.c in uv.gyp
1b32de7 
PR-URL: nodejs#49410
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uv_barrier_init function symbol not found in Node.js 20.3 onwards
9 participants
@santigimeno @nodejs-github-bot @bnoordhuis @lpinca @anonrig @gengjiawen @richardlau @ruyadorno @debadree25