Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextify: use offset/length from Uint8Array #4947

Closed
wants to merge 1 commit into from
Closed

contextify: use offset/length from Uint8Array #4947

wants to merge 1 commit into from

Commits on Jan 29, 2016

  1. contextify: use offset/length from Uint8Array 

    Do not blindly take data from underlying `ArrayBuffer`, use
`ByteOffset`/`ByteLength` of `Uint8Array` itself.

Additionally, fix tests that weren't actually properly running because
of V8's internal code cache. The code should be different, otherwise the
cached data won't be used at all.

Fix: nodejs#4939
    @indutny
    indutny committed Jan 29, 2016
    Configuration menu
    Copy the full SHA
    a15a7cb View commit details
    Browse the repository at this point in the history