Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src, doc: improve documentation and error message for ICU data fallback #49666

Closed
wants to merge 2 commits into from
Closed

src, doc: improve documentation and error message for ICU data fallback #49666

wants to merge 2 commits into from

Commits on Sep 18, 2023

  1. src: improve error message when ICU data cannot be initialized 

    Previously when we fail to initialize ICU data, the error message is

```
could not initialize ICU (check NODE_ICU_DATA or --icu-data-dir
parameters)
```

This patch updates it to something similar to:

```
U_FILE_ACCESS_ERROR: Could not initialize ICU. Check the directory
specified by NODE_ICU_DATA or --icu-data-dir contains icudt73l.dat
and it's readable
```

Where the expected data file name is the same as U_ICUDATA_NAME.
    @joyeecheung
    joyeecheung committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    989f265 View commit details
    Browse the repository at this point in the history

  2. doc: improve documentation about ICU data fallback 

    This patch:

- Documents `--with-icu-default-data-dir` and its precedence
- Elaborates a bit more about the format of the name of the expected
  data file.
    @joyeecheung
    joyeecheung committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    930aba9 View commit details
    Browse the repository at this point in the history