Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: reset the cwd cache before execution #49684

Merged
merged 11 commits into from
Sep 21, 2023
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ process.abort = unavailable('process.abort()');
process.chdir = unavailable('process.chdir()');
process.umask = wrappedUmask;
process.cwd = rawMethods.cwd;
process.cwd.resetCwdCache = () => {};
joyeecheung marked this conversation as resolved.
Show resolved Hide resolved

if (credentials.implementsPosixCredentials) {
process.initgroups = unavailable('process.initgroups()');
Expand Down
5 changes: 5 additions & 0 deletions lib/internal/bootstrap/switches/does_own_process_state.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ process.abort = rawMethods.abort;
process.umask = wrappedUmask;
process.chdir = wrappedChdir;
process.cwd = wrappedCwd;
process.cwd.resetCwdCache = resetCwdCache;

if (credentials.implementsPosixCredentials) {
const wrapped = wrapPosixCredentialSetters(credentials);
Expand Down Expand Up @@ -107,6 +108,10 @@ function wrapPosixCredentialSetters(credentials) {
// directory is changed by `chdir`, it'll be updated.
let cachedCwd = '';

function resetCwdCache() {
cachedCwd = '';
joyeecheung marked this conversation as resolved.
Show resolved Hide resolved
}

function wrappedChdir(directory) {
validateString(directory, 'directory');
rawMethods.chdir(directory);
Expand Down
1 change: 1 addition & 0 deletions lib/internal/process/pre_execution.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ function patchProcessObject(expandArgv1) {
process.exitCode = undefined;
process._exiting = false;
process.argv[0] = process.execPath;
process.cwd.resetCwdCache();

if (expandArgv1 && process.argv[1] &&
!StringPrototypeStartsWith(process.argv[1], '-')) {
Expand Down
10 changes: 10 additions & 0 deletions test/fixtures/snapshot/cwd.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
const {
setDeserializeMainFunction,
} = require('v8').startupSnapshot;

// To make sure the cwd is present in the cache
process.cwd();

setDeserializeMainFunction(() => {
console.log(process.cwd());
});
49 changes: 49 additions & 0 deletions test/parallel/test-snapshot-cwd.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
'use strict';

// This tests that user land snapshots works when the instance restored from
// the snapshot is launched with -p and -e

arcanis marked this conversation as resolved.
Show resolved Hide resolved
require('../common');
const assert = require('assert');
const { spawnSync } = require('child_process');
aduh95 marked this conversation as resolved.
Show resolved Hide resolved
const tmpdir = require('../common/tmpdir');
const fixtures = require('../common/fixtures');
const fs = require('fs');
const path = require('path');

tmpdir.refresh();
const blobPath = tmpdir.resolve('snapshot.blob');
const file = fixtures.path('snapshot', 'cwd.js');

const subdir = path.join(tmpdir.path, 'foo');
arcanis marked this conversation as resolved.
Show resolved Hide resolved
fs.mkdirSync(subdir);

{
// Create the snapshot.
const child = spawnSync(process.execPath, [
'--snapshot-blob',
blobPath,
'--build-snapshot',
file,
], {
cwd: tmpdir.path,
encoding: 'utf8'
});

assert.strictEqual(child.status, 0);
}

{
// Check a custom works.
arcanis marked this conversation as resolved.
Show resolved Hide resolved
arcanis marked this conversation as resolved.
Show resolved Hide resolved
const child = spawnSync(process.execPath, [
'--snapshot-blob',
blobPath,
file,
], {
cwd: subdir,
encoding: 'utf8'
});

assert.strictEqual(child.status, 0);
assert.strictEqual(child.stdout, `${subdir}\n`);
}