lib: improve performance of validateStringArray and validateBooleanArray #49756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
Sep 21, 2023
|
Since you are creating a new benchmark suite, you need to also create the appropriate test for it. Similar to https://github.com/nodejs/node/blob/main/test/benchmark/test-bechmark-readline.js |
anonrig
added
the
performance
anonrig
added
author ready
anonrig
approved these changes
Sep 22, 2023
github-actions
bot
removed
the
request-ci
20 tasks
anonrig
approved these changes
Sep 24, 2023
github-actions
bot
removed
the
request-ci
trivikr
approved these changes
Sep 25, 2023
github-actions
bot
removed
the
request-ci
21 tasks
|
Can this please be merged? I think I improved the performance of parseFileMode and I would like to use the benchmark in this PR. function parseFileMode(value, name, def) {
value ??= def;
if (typeof value === 'string') {
if (value === '') {
throw new ERR_INVALID_ARG_VALUE(name, value, modeDesc);
}
let result = 0;
for (let i = 0; i < value.length; ++i) {
result <<= 3;
switch (value[i]) {
case '7':
result += 7;
break;
case '6':
result += 6;
break;
case '5':
result += 5;
break;
case '4':
result += 4;
break;
case '3':
result += 3;
break;
case '2':
result += 2;
break;
case '1':
result += 1;
break;
case '0':
break;
default:
throw new ERR_INVALID_ARG_VALUE(name, value, modeDesc);
}
}
return result;
}
validateUint32(value, name);
return value;
} |
|
It needs a benchmark run |
30 tasks
|
The failing tests have to be unrelated. Can you retrigger the tests, please? or should i rebase, because the fixes for the failing tests is in master already? |
29 tasks
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/49756 ✔ Done loading data for nodejs/node/pull/49756 ----------------------------------- PR info ------------------------------------ Title lib: improve performance of validateStringArray and validateBooleanArray (#49756) Author Aras Abbasi (@Uzlopak) Branch Uzlopak:improve-perf-array-validators -> nodejs:main Labels performance, author ready, needs-ci, needs-benchmark-ci Commits 1 - lib: improve performance of validateStringArray and validateBooleanArray Committers 1 - uzlopak PR-URL: https://github.com/nodejs/node/pull/49756 Reviewed-By: Yagiz Nizipli Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/49756 Reviewed-By: Yagiz Nizipli Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - lib: improve performance of validateStringArray and validateBooleanArray ℹ This PR was created on Thu, 21 Sep 2023 21:54:17 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49756#pullrequestreview-1641142923 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/49756#pullrequestreview-1641181220 ✔ Last GitHub CI successful ℹ Last Benchmark CI on 2023-09-27T13:36:16Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1423 ℹ Last Full PR CI on 2023-10-22T19:56:46Z: https://ci.nodejs.org/job/node-test-pull-request/55130/ - Querying data for job/node-test-pull-request/55130/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6606164183 |
nodejs-github-bot
added
the
commit-queue-failed
anonrig
approved these changes
Oct 22, 2023
anonrig
added
commit-queue
|
|
nodejs-github-bot
removed
the
commit-queue
|
Landed in a58ffad |
26 tasks
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
PR-URL: #49756 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Oct 24, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49756 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49756 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of calling the validateString/validateBoolean function, where we are forced to create strings, which we potentially dont need, we create the string only when needed.
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1423