Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: use validateFunction for options.checkServerIdentity #49896

Merged
merged 2 commits into from
Sep 30, 2023
Merged

tls: use validateFunction for options.checkServerIdentity #49896

merged 2 commits into from
Sep 30, 2023

Commits on Sep 27, 2023

  1. tls: use validateFunction for options.checkServerIdentity 

    If user uses invalid type for `options.checkServerIdentity`
in tls.connect(), it's not internal issue of Node.js. So
validateFunction() is more proper than assert().

Fixes: nodejs#49839
    @deokjinkim
    deokjinkim committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    d5d2fa3 View commit details
    Browse the repository at this point in the history

  2. Update test/parallel/test-tls-basic-validations.js 

    Co-authored-by: Tobias Nießen <tniessen@tnie.de>
    @deokjinkim @tniessen
    deokjinkim and tniessen committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9ca4271 View commit details
    Browse the repository at this point in the history