Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: limit Buffer::kMaxLength to 1TB #49930

Closed
wants to merge 2 commits into from
Closed

src: limit Buffer::kMaxLength to 1TB #49930

wants to merge 2 commits into from

Commits on Sep 28, 2023

  1. src: limit Buffer::kMaxLength to 1TB 

    This change has no real effect for now, as the V8 maximum typed array
length is still 2**32. When V8 is updated to version 11.9 or later, the
limit will be 2**53-1 on 64-bit architectures, much larger than any
reasonable amount of RAM. This caps the limit at 1TB, which is already
very large and corresponds to the maximum memory that AddressSanitizer
allows to allocate.

Refs: nodejs#49876
Refs: nodejs/node-v8#268
    @targos
    targos committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    12f841d View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. fixup! src: limit Buffer::kMaxLength to 1TB

    @targos
    targos committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    0c15d82 View commit details
    Browse the repository at this point in the history