test: improve code coverage of diagnostics_channel #50053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
MrJithil
force-pushed
the
code-coverage-improvement-diagnostics_channel
branch
4 times, most recently
from
3789b15 to
316f34a
Compare
MrJithil
force-pushed
the
code-coverage-improvement-diagnostics_channel
branch
from
316f34a to
f23b7d2
Compare
Flarna
reviewed
Oct 10, 2023
test/parallel/test-diagnostics-channel-tracing-channel-args-types.js
Outdated
Show resolved
Hide resolved
Flarna
added
diagnostics_channel
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
test: improve code coverage of diagnostics_channel
MrJithil
force-pushed
the
code-coverage-improvement-diagnostics_channel
branch
from
f23b7d2 to
a5b62f8
Compare
|
@Flarna Please review. |
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
the
author ready
Flarna
approved these changes
Oct 10, 2023
30 tasks
Flarna
approved these changes
Oct 11, 2023
|
@Flarna please help to re run the C I. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Flarna
added
review wanted
nodejs-github-bot
removed
the
commit-queue
|
Landed in a8af24b |
targos
pushed a commit
that referenced
this pull request
Oct 23, 2023
test: improve code coverage of diagnostics_channel PR-URL: #50053 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
test: improve code coverage of diagnostics_channel PR-URL: nodejs#50053 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
test: improve code coverage of diagnostics_channel PR-URL: #50053 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: improve code coverage of diagnostics_channel
Current coverage report: https://app.codecov.io/gh/nodejs/node/blob/main/lib%2Fdiagnostics_channel.js