Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve error performance of readdirSync #50131

Merged
merged 1 commit into from
Oct 14, 2023
Merged

fs: improve error performance of readdirSync #50131

merged 1 commit into from
Oct 14, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 10, 2023 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. typings labels Oct 10, 2023
@anonrig anonrig mentioned this pull request Oct 10, 2023
Open
@anonrig anonrig force-pushed the fs-readdir-sync branch 2 times, most recently from 769e7d4 to 76e84e4 Compare October 10, 2023 23:46
@anonrig anonrig marked this pull request as ready for review October 10, 2023 23:46
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@github-actions
Copy link
Contributor

Failed to start CI
node:internal/modules/cjs/loader:1028
  const err = new Error(message);
              ^

Error: Cannot find module 'call-bind'

Require stack:


    

  • /opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js
    
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1028:15)
    
at Function.Module._load (node:internal/modules/cjs/loader:873:27)
    
at Module.require (node:internal/modules/cjs/loader:1100:19)
    
at require (node:internal/modules/cjs/helpers:119:18)
    
at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js:4:16)
    
at Module._compile (node:internal/modules/cjs/loader:1198:14)
    
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    
at Module.load (node:internal/modules/cjs/loader:1076:32)
    
at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    
at ModuleWrap. (node:internal/modules/esm/translators:169:29) {
    
code: 'MODULE_NOT_FOUND',
    
requireStack: [
    
'/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js'
    
]
    
}
https://github.com/nodejs/node/actions/runs/6482563573

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Oct 11, 2023
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Oct 11, 2023
@github-actions
Copy link
Contributor

Failed to start CI
node:internal/modules/cjs/loader:1028
  const err = new Error(message);
              ^

Error: Cannot find module 'call-bind'

Require stack:


    

  • /opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js
    
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1028:15)
    
at Function.Module._load (node:internal/modules/cjs/loader:873:27)
    
at Module.require (node:internal/modules/cjs/loader:1100:19)
    
at require (node:internal/modules/cjs/helpers:119:18)
    
at Object. (/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js:4:16)
    
at Module._compile (node:internal/modules/cjs/loader:1198:14)
    
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    
at Module.load (node:internal/modules/cjs/loader:1076:32)
    
at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    
at ModuleWrap. (node:internal/modules/esm/translators:169:29) {
    
code: 'MODULE_NOT_FOUND',
    
requireStack: [
    
'/opt/hostedtoolcache/node/16.20.2/x64/lib/node_modules/@node-core/utils/node_modules/@ljharb/through/index.js'
    
]
    
}
https://github.com/nodejs/node/actions/runs/6484034168

@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Oct 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54705/

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 12, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54731/

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54767/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54769/

mcollina
mcollina approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 14, 2023
@anonrig
Copy link
Member Author

anonrig commented Oct 14, 2023

cc @nodejs/cpp-reviewers @nodejs/fs

@anonrig anonrig added the review wanted PRs that need reviews. label Oct 14, 2023
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit 18a8187 into nodejs:main Oct 14, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 18a8187

@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
fs: improve error performance of readdirSync
b7b3ef0 
PR-URL: nodejs#50131
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
fs: improve error performance of readdirSync
06aa4b9 
PR-URL: #50131
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@mcollina mcollina mcollina approved these changes

@Qard Qard Awaiting requested review from Qard

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anonrig @nodejs-github-bot @mcollina @GeoffreyBooth @richardlau