deps: update undici to 5.26.4 #50274

nodejs-github-bot · 2023-10-19T09:23:04Z

This is an automated update of undici to 5.26.4.

nodejs-github-bot · 2023-10-19T12:11:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54999/

nodejs-github-bot · 2023-10-19T16:25:35Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55010/

nodejs-github-bot · 2023-10-19T20:58:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55023/

nodejs-github-bot · 2023-10-20T08:28:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/55037/

panva · 2023-10-20T08:30:58Z

deps/undici/src/package-lock.json

This package-lock.json is not part of the source code and was generated during the build in nodejs/node GitHub Actions, should it be part of deps/undici and commited to nodejs/node?

package-lock is hardly useful (for undici and this library). We can update the script and remove the package-lock file if you prefer.

I think landing this asap would be better tho.

panva · 2023-10-20T08:32:32Z

deps/undici/src/package.json

  ],
  "scripts": {
-    "build:node": "node scripts/esbuild-build.mjs",
+    "build:node": "npx esbuild@0.19.4 index-fetch.js --bundle --platform=node --outfile=undici-fetch.js --define:esbuildDetection=1 --keep-names",


How is this build dependency, fixed to be esbuild@0.19.4, version-automated to be maintained up to date?

This was done like that in undici, and we switched to a build script in a hurry for the security release. https://github.com/nodejs/undici/blob/4006aaf43ac8b30e16d6d3b89fa2e0df4b7eef33/package.json#L73.

@panva undici always pinned esbuild's version here. I updated it from some version of 0.14. Realistically we would want to get rid of esbuild entirely, as it's caused nothing but issues (hinting at my next pr probably).

mcollina · 2023-10-20T09:16:32Z

I kindly ask to fast-track this to be able to fix v18.x v20.x and v21.x asap:

#50263

github-actions · 2023-10-20T09:16:53Z

Fast-track has been requested by @mcollina. Please 👍 to approve.

nodejs-github-bot · 2023-10-22T09:04:44Z

Commit Queue failed

- Loading data for nodejs/node/pull/50274
✔  Done loading data for nodejs/node/pull/50274
----------------------------------- PR info ------------------------------------
Title      deps: update undici to 5.26.4 (#50274)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-undici -> nodejs:main
Labels     lib / src, fast-track, needs-ci, dependencies, lts-watch-v18.x, lts-watch-v20.x
Commits    2
 - deps: update undici to 5.26.4
 - deps: update undici to 5.26.4
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/50274
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50274
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: update undici to 5.26.4
   ℹ  This PR was created on Thu, 19 Oct 2023 09:23:04 GMT
   ✔  Approvals: 2
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687504480
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687505651
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-20T08:28:39Z: https://ci.nodejs.org/job/node-test-pull-request/55037/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - deps: update undici to 5.26.4
- Querying data for job/node-test-pull-request/55037/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6602832895

nodejs-github-bot · 2023-10-22T12:13:04Z

Commit Queue failed

- Loading data for nodejs/node/pull/50274 ✔ Done loading data for nodejs/node/pull/50274 ----------------------------------- PR info ------------------------------------ Title deps: update undici to 5.26.4 (#50274) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-undici -> nodejs:main Labels lib / src, fast-track, needs-ci, dependencies, lts-watch-v18.x, lts-watch-v20.x Commits 2 - deps: update undici to 5.26.4 - deps: update undici to 5.26.4 Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/50274 Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50274 Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Matteo Collina -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 19 Oct 2023 09:23:04 GMT ✔ Approvals: 3 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687504480 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687505651 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1691423089 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-10-22T09:04:44Z: https://ci.nodejs.org/job/node-test-pull-request/55037/ - Querying data for job/node-test-pull-request/55037/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50274 From https://github.com/nodejs/node * branch refs/pull/50274/merge -> FETCH_HEAD ✔ Fetched commits as 7dc74a045118..e56f840313f4 -------------------------------------------------------------------------------- Auto-merging doc/contributing/maintaining/maintaining-dependencies.md [main 1445ed7391] deps: update undici to 5.26.4 Date: Thu Oct 19 09:23:01 2023 +0000 10 files changed, 15449 insertions(+), 116 deletions(-) create mode 100644 deps/undici/src/package-lock.json delete mode 100644 deps/undici/src/scripts/esbuild-build.mjs [main d4b24a0cd6] deps: update undici to 5.26.4 Date: Sun Oct 22 00:28:59 2023 +0000 1 file changed, 108 insertions(+), 73 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
deps: update undici to 5.26.4

PR-URL: #50274
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

[detached HEAD 02ac09c72c] deps: update undici to 5.26.4
Date: Thu Oct 19 09:23:01 2023 +0000
10 files changed, 15449 insertions(+), 116 deletions(-)
create mode 100644 deps/undici/src/package-lock.json
delete mode 100644 deps/undici/src/scripts/esbuild-build.mjs
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
deps: update undici to 5.26.4

PR-URL: #50274
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

[detached HEAD 150db3e942] deps: update undici to 5.26.4
Date: Sun Oct 22 00:28:59 2023 +0000
1 file changed, 108 insertions(+), 73 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6603683952

nodejs-github-bot · 2023-10-22T15:20:50Z

Landed in 76f59b4

PR-URL: #50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

davidlehn · 2023-10-24T16:43:13Z

@mcollina It looks like the 5.26.4 update made it into v21.1.0, but not v20.9.0 or v18.x yet. #50263 is still an issue in 20 and 18. These issues are closed now due to the v21 fix but the problem remains. Where is this being tracked and what's the status now?

mcollina · 2023-10-25T16:44:33Z

@nodejs/releasers we need a quick backport to v18.x and v20.x for this one to fix a problematic regression.

PR-URL: #50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos · 2023-10-25T19:31:52Z

I just cherry-picked it to v18.x-staging.

PR-URL: #50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

richardlau · 2023-10-26T11:58:38Z

76f59b4 has also been cherry-picked onto v20.x-staging.

PR-URL: nodejs#50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

PR-URL: nodejs/node#50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deps: update undici to 5.26.4

2bb23ad

nodejs-github-bot added dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 19, 2023

aduh95 mentioned this pull request Oct 19, 2023

deps: update undici to 5.26.4 #50272

Closed

tniessen approved these changes Oct 19, 2023

View reviewed changes

richardlau approved these changes Oct 19, 2023

View reviewed changes

richardlau added lts-watch-v18.x PRs that may need to be released in v18.x. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 19, 2023

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2023

targos linked an issue Oct 19, 2023 that may be closed by this pull request

Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options #50263

Closed

mattcollier mentioned this pull request Oct 19, 2023

Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options #50263

Closed

github-actions bot mentioned this pull request Oct 20, 2023

CI Reliability 2023-10-20 nodejs/reliability#692

Open

20 tasks

richardlau added the lts-watch-v20.x PRs that may need to be released in v20.x label Oct 20, 2023

panva reviewed Oct 20, 2023

View reviewed changes

mcollina added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 20, 2023

This was referenced Oct 21, 2023

CI Reliability 2023-10-21 nodejs/reliability#693

Open

CI Reliability 2023-10-22 nodejs/reliability#694

Open

deps: update undici to 5.26.4

e56f840

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023

nodejs-github-bot merged commit 76f59b4 into main Oct 22, 2023
37 checks passed

nodejs-github-bot deleted the actions/tools-update-undici branch October 22, 2023 15:20

targos pushed a commit that referenced this pull request Oct 23, 2023

deps: update undici to 5.26.4

0005317

PR-URL: #50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos mentioned this pull request Oct 23, 2023

v21.1.0 release proposal #50335

Merged

bbowman mentioned this pull request Oct 25, 2023

Node 18.18.2 Incorrectly copies headers onto fetches nodejs/undici#2374

Closed

targos pushed a commit that referenced this pull request Oct 25, 2023

deps: update undici to 5.26.4

7ccb478

PR-URL: #50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

richardlau pushed a commit that referenced this pull request Oct 26, 2023

deps: update undici to 5.26.4

61b4afb

PR-URL: #50274 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added backported-to-v18.x PRs backported to the v18.x-staging branch. and removed lts-watch-v18.x PRs that may need to be released in v18.x. labels Oct 27, 2023

richardlau added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Oct 31, 2023

sholladay mentioned this pull request Nov 3, 2023

Header not set on node version 18.18.2 sindresorhus/ky#535

Closed

targos mentioned this pull request Nov 12, 2023

v20.10.0 release proposal #50682

Merged

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

codebytere mentioned this pull request Jan 17, 2024

fix: undici incorrectly copies headers onto fetches electron/electron#41019

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update undici to 5.26.4 #50274

deps: update undici to 5.26.4 #50274

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 20, 2023

panva Oct 20, 2023 •

edited

Loading

mcollina Oct 20, 2023

panva Oct 20, 2023 •

edited

Loading

mcollina Oct 20, 2023

KhafraDev Oct 22, 2023

mcollina commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

nodejs-github-bot commented Oct 22, 2023

nodejs-github-bot commented Oct 22, 2023

PR-URL: #50274
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

PR-URL: #50274
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Oct 22, 2023

davidlehn commented Oct 24, 2023

mcollina commented Oct 25, 2023

targos commented Oct 25, 2023

richardlau commented Oct 26, 2023

deps: update undici to 5.26.4 #50274

deps: update undici to 5.26.4 #50274

Conversation

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 19, 2023

nodejs-github-bot commented Oct 20, 2023

panva Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

mcollina Oct 20, 2023

Choose a reason for hiding this comment

panva Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

mcollina Oct 20, 2023

Choose a reason for hiding this comment

KhafraDev Oct 22, 2023

Choose a reason for hiding this comment

mcollina commented Oct 20, 2023

github-actions bot commented Oct 20, 2023

nodejs-github-bot commented Oct 22, 2023

nodejs-github-bot commented Oct 22, 2023

PR-URL: #50274 Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: Richard Lau rlau@redhat.com Reviewed-By: Matteo Collina matteo.collina@gmail.com

PR-URL: #50274 Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: Richard Lau rlau@redhat.com Reviewed-By: Matteo Collina matteo.collina@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Oct 22, 2023

davidlehn commented Oct 24, 2023

mcollina commented Oct 25, 2023

targos commented Oct 25, 2023

richardlau commented Oct 26, 2023

panva Oct 20, 2023 •

edited

Loading

panva Oct 20, 2023 •

edited

Loading

PR-URL: #50274
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

PR-URL: #50274
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com