test: improve watch mode test #50319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
MoLow
added
the
commit-queue-squash
cjihrig
approved these changes
Oct 21, 2023
GeoffreyBooth
approved these changes
Oct 21, 2023
anonrig
approved these changes
Oct 21, 2023
github-actions
bot
removed
the
request-ci
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 41a3878 |
targos
pushed a commit
that referenced
this pull request
Oct 24, 2023
PR-URL: #50319 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50319 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50319 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this test was changed to enable landing of #50096
the original intent was to make sure the
--importis only handled by the inner process spawned by watch mode, and not the outer one.