Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Crypto.markdown 'RSA-SHA256' should be uppercase #5044

Closed
wants to merge 3 commits into from

Conversation

raineroviir
Copy link
Contributor

doc: Crypto.markdown 'RSA-SHA256' should be uppercase

The RSA-SHA256 string should be uppercase
@r-52 r-52 added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. lts-watch-v4.x labels Feb 2, 2016
@mscdex
Copy link
Contributor

mscdex commented Feb 2, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Feb 2, 2016

LGTM

@bnoordhuis
Copy link
Member

LGTM but the commit log should follow the style guide from CONTRIBUTING.md.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 2, 2016

LGTM

@raineroviir raineroviir changed the title Update crypto.markdown crypto, doc: Crypto.markdown 'RSA-SHA256' should be uppercase Feb 2, 2016
@raineroviir raineroviir changed the title crypto, doc: Crypto.markdown 'RSA-SHA256' should be uppercase doc: Crypto.markdown 'RSA-SHA256' should be uppercase Feb 2, 2016
@stevemao
Copy link
Contributor

stevemao commented Feb 2, 2016

@raineroviir you need to change the commit message and force push to your branch.

@raineroviir
Copy link
Contributor Author

@stevemao I was able to amend the commit message and create a detached head but when I try to force push to my branch it says nothing was changed

@stevemao
Copy link
Contributor

stevemao commented Feb 2, 2016

Don't checkout the previous commit.
The easiest way to do this is git commit --amend fix the commit message then git push -f

@raineroviir https://help.github.com/articles/changing-a-commit-message/

doc: Crypto.markdown 'RSA-SHA256' should be uppercase
doc: Crypto.markdown 'RSA-SHA256' should be uppercase
@raineroviir
Copy link
Contributor Author

@stevemao thanks! decc2e1 commit message hasn't changed but I believe I made the changes

@stevemao
Copy link
Contributor

stevemao commented Feb 3, 2016

Well, I guess you probably need to squash now... But I think someone can do it on merge so don't worry!

bnoordhuis pushed a commit that referenced this pull request Feb 3, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis
Copy link
Member

@raineroviir Here is what I would do:

  1. git reflog and find the hash of your original commit.
  2. git reset --hard <commit>
  3. git commit --amend
  4. git push your-remote +HEAD:patch-1

I landed your patch with a slightly amended commit log (< 50 characters) in commit 977159f. Thanks!

@bnoordhuis bnoordhuis closed this Feb 3, 2016
@raineroviir
Copy link
Contributor Author

Thank you!

rvagg pushed a commit that referenced this pull request Feb 8, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 22, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Fixes: #5031
PR-URL: #5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Fixes: nodejs#5031
PR-URL: nodejs#5044
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants