-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Crypto.markdown 'RSA-SHA256' should be uppercase #5044
Conversation
The RSA-SHA256 string should be uppercase
LGTM |
1 similar comment
LGTM |
LGTM but the commit log should follow the style guide from CONTRIBUTING.md. |
LGTM |
@raineroviir you need to change the commit message and force push to your branch. |
@stevemao I was able to amend the commit message and create a detached head but when I try to force push to my branch it says nothing was changed |
Don't checkout the previous commit. @raineroviir https://help.github.com/articles/changing-a-commit-message/ |
doc: Crypto.markdown 'RSA-SHA256' should be uppercase
doc: Crypto.markdown 'RSA-SHA256' should be uppercase
Well, I guess you probably need to squash now... But I think someone can do it on merge so don't worry! |
@raineroviir Here is what I would do:
I landed your patch with a slightly amended commit log (< 50 characters) in commit 977159f. Thanks! |
Thank you! |
Fixes: nodejs#5031 PR-URL: nodejs#5044 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
doc: Crypto.markdown 'RSA-SHA256' should be uppercase