doc: deprecation code for isWebAssemblyCompiledModule #50486

marco-ippolito · 2023-10-31T10:03:58Z

It was missing deprecation code

nodejs-github-bot · 2023-11-11T16:25:38Z

Commit Queue failed

- Loading data for nodejs/node/pull/50486 ✔ Done loading data for nodejs/node/pull/50486 ----------------------------------- PR info ------------------------------------ Title doc: deprecation code for isWebAssemblyCompiledModule (#50486) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:feat/deprecate-isWebAssemblyCompiledModule -> nodejs:main Labels doc, deprecations Commits 4 - doc: deprecation code for isWebAssemblyCompiledModule - addded pr url - Update deprecations.md - fix Committers 2 - Marco Ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/50486 Reviewed-By: Paolo Insogna Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50486 Reviewed-By: Paolo Insogna Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 31 Oct 2023 10:03:58 GMT ✔ Approvals: 2 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/50486#pullrequestreview-1708249819 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50486#pullrequestreview-1726083822 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50486 From https://github.com/nodejs/node * branch refs/pull/50486/merge -> FETCH_HEAD ✔ Fetched commits as 83e6350b826a..3f0db4ecc604 -------------------------------------------------------------------------------- [main 25fe4458f4] doc: deprecation code for isWebAssemblyCompiledModule Author: Marco Ippolito Date: Tue Oct 31 12:00:56 2023 +0200 1 file changed, 18 insertions(+) [main 68ab441ba5] addded pr url Author: Marco Ippolito Date: Tue Oct 31 12:04:25 2023 +0200 1 file changed, 1 insertion(+), 1 deletion(-) [main 416bf34715] Update deprecations.md Author: Marco Ippolito Date: Tue Oct 31 12:17:41 2023 +0200 1 file changed, 2 insertions(+), 2 deletions(-) [main 1e3b421ffb] fix Author: Marco Ippolito Date: Tue Oct 31 14:16:18 2023 +0200 1 file changed, 2 insertions(+), 2 deletions(-) ✔ Patches applied There are 4 commits in the PR. Attempting autorebase. Rebasing (2/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: deprecation code for isWebAssemblyCompiledModule

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 5cb6020934] doc: deprecation code for isWebAssemblyCompiledModule
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Tue Oct 31 12:00:56 2023 +0200
1 file changed, 18 insertions(+)
Rebasing (3/8)
Rebasing (4/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
addded pr url

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD f0f9b0f266] addded pr url
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Tue Oct 31 12:04:25 2023 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (5/8)
Rebasing (6/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update deprecations.md

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 0543c368a6] Update deprecations.md
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Tue Oct 31 12:17:41 2023 +0200
1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (7/8)
Rebasing (8/8)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD b68af47e1d] fix
Author: Marco Ippolito marcoippolito54@gmail.com
Date: Tue Oct 31 14:16:18 2023 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6835327454

nodejs-github-bot · 2023-11-11T19:24:30Z

Commit Queue failed

- Loading data for nodejs/node/pull/50486
✔  Done loading data for nodejs/node/pull/50486
----------------------------------- PR info ------------------------------------
Title      doc: deprecation code for isWebAssemblyCompiledModule (#50486)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/deprecate-isWebAssemblyCompiledModule -> nodejs:main
Labels     doc, deprecations
Commits    1
 - doc: deprecation code for isWebAssemblyCompiledModule
Committers 1
 - marco-ippolito 
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: deprecation code for isWebAssemblyCompiledModule
   ℹ  This PR was created on Tue, 31 Oct 2023 10:03:58 GMT
   ✔  Approvals: 2
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/50486#pullrequestreview-1708249819
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50486#pullrequestreview-1726083822
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6836131662

targos · 2023-11-12T09:06:04Z

Please correct the commit message (it's missing a verb)

nodejs-github-bot · 2023-11-22T16:32:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/50486
✔  Done loading data for nodejs/node/pull/50486
----------------------------------- PR info ------------------------------------
Title      doc: deprecation code for isWebAssemblyCompiledModule (#50486)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:feat/deprecate-isWebAssemblyCompiledModule -> nodejs:main
Labels     doc, deprecations
Commits    1
 - doc: create deprecation code for isWebAssemblyCompiledModule
Committers 1
 - marco-ippolito 
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - doc: create deprecation code for isWebAssemblyCompiledModule
   ℹ  This PR was created on Tue, 31 Oct 2023 10:03:58 GMT
   ✔  Approvals: 2
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/50486#pullrequestreview-1708249819
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50486#pullrequestreview-1726083822
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6960144937

nodejs-github-bot · 2023-11-22T17:20:48Z

Landed in 3782006

PR-URL: #50486 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: nodejs#50486 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #50486 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 31, 2023

ShogunPanda approved these changes Nov 1, 2023

View reviewed changes

jasnell approved these changes Nov 11, 2023

View reviewed changes

jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 11, 2023

marco-ippolito force-pushed the feat/deprecate-isWebAssemblyCompiledModule branch 2 times, most recently from 65723c3 to b97c02b Compare November 11, 2023 16:36

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 11, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 11, 2023

UlisesGascon approved these changes Nov 12, 2023

View reviewed changes

doc: create deprecation code for isWebAssemblyCompiledModule

38f52f8

marco-ippolito force-pushed the feat/deprecate-isWebAssemblyCompiledModule branch from b97c02b to 38f52f8 Compare November 13, 2023 08:26

marco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 13, 2023

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 22, 2023

RafaelGSS approved these changes Nov 22, 2023

View reviewed changes

marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 22, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2023

nodejs-github-bot merged commit 3782006 into nodejs:main Nov 22, 2023
22 checks passed

RafaelGSS mentioned this pull request Nov 28, 2023

v21.3.0 proposal #50954

Merged

UlisesGascon mentioned this pull request Dec 12, 2023

v20.11.0 proposal #51124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: deprecation code for isWebAssemblyCompiledModule #50486

doc: deprecation code for isWebAssemblyCompiledModule #50486

marco-ippolito commented Oct 31, 2023 •

edited

Loading

nodejs-github-bot commented Nov 11, 2023

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Nov 11, 2023

targos commented Nov 12, 2023

nodejs-github-bot commented Nov 22, 2023

nodejs-github-bot commented Nov 22, 2023

doc: deprecation code for isWebAssemblyCompiledModule #50486

doc: deprecation code for isWebAssemblyCompiledModule #50486

Conversation

marco-ippolito commented Oct 31, 2023 • edited Loading

nodejs-github-bot commented Nov 11, 2023

PR-URL: #50486 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486 Reviewed-By: Paolo Insogna paolo@cowtech.it Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/main.

nodejs-github-bot commented Nov 11, 2023

targos commented Nov 12, 2023

nodejs-github-bot commented Nov 22, 2023

nodejs-github-bot commented Nov 22, 2023

marco-ippolito commented Oct 31, 2023 •

edited

Loading

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #50486
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: James M Snell jasnell@gmail.com