Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: handle errors from uv_pipe_connect2() #50657

Merged
merged 1 commit into from
Nov 12, 2023
Merged

src: handle errors from uv_pipe_connect2() #50657

merged 1 commit into from
Nov 12, 2023

Conversation

deokjinkim
Copy link
Contributor

@deokjinkim deokjinkim commented Nov 10, 2023 •
edited
Loading

We need to handle errors from uv_pipe_connect2()
because return type is int.

Fixes: #50652
Refs: #49667
Refs: libuv/libuv#4030

@bnoordhuis I didn't find caller of PipeWrap::Connect yet. Can I get some hint?

@deokjinkim
src: handle errors from uv_pipe_connect2()
68ce7f9 
We need to handle errors from uv_pipe_connect2()
because return type is `int`.

Fixes: nodejs#50652
Refs: nodejs#49667
Refs: libuv/libuv#4030
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Nov 10, 2023
bnoordhuis
bnoordhuis approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W.r.t. your question: it's a binding method, it's only called from JS code, not C++.

@deokjinkim deokjinkim added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55537/

@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55553/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55561/

@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Open
18 tasks
@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2023
@deokjinkim deokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 9134f4a into nodejs:main Nov 12, 2023
66 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9134f4a

This was referenced Nov 13, 2023
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 23, 2023
@deokjinkim @targos
src: handle errors from uv_pipe_connect2()
57587de 
We need to handle errors from uv_pipe_connect2()
because return type is `int`.

Fixes: #50652
Refs: #49667
Refs: libuv/libuv#4030
PR-URL: #50657
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@deokjinkim @UlisesGascon
src: handle errors from uv_pipe_connect2()
c253e39 
We need to handle errors from uv_pipe_connect2()
because return type is `int`.

Fixes: #50652
Refs: #49667
Refs: libuv/libuv#4030
PR-URL: #50657
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theanarkh theanarkh theanarkh approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PipeWrap::Connect() should handle errors from uv_pipe_connect2()
5 participants
@deokjinkim @nodejs-github-bot @bnoordhuis @jasnell @theanarkh