src: avoid silent coercion to signed/unsigned int #50663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be accurate about signedness and bit widths.
|
Review requested:
|
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Nov 11, 2023
marco-ippolito
approved these changes
Nov 11, 2023
tniessen
added
author ready
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Nov 11, 2023
lpinca
approved these changes
Nov 12, 2023
targos
added
commit-queue
|
@targos Can I ask why |
targos
removed
the
dont-land-on-v20.x
|
Just a mistake, sorry. |
nodejs-github-bot
removed
the
commit-queue
|
Landed in a1a70db |
targos
pushed a commit
that referenced
this pull request
Nov 23, 2023
Be accurate about signedness and bit widths. PR-URL: #50663 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
Be accurate about signedness and bit widths. PR-URL: #50663 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jan 10, 2024
zcbenz
pushed a commit
to electron/electron
that referenced
this pull request
Jan 12, 2024
zcbenz
pushed a commit
to electron/electron
that referenced
this pull request
Jan 12, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jan 15, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jan 15, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jan 16, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jan 18, 2024
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Jan 18, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jan 18, 2024
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Jan 18, 2024
* chore: bump node in DEPS to v20.11.0 * module: bootstrap module loaders in shadow realm nodejs/node#48655 * src: add commit hash shorthand in zlib version nodejs/node#50158 * v8,tools: expose necessary V8 defines nodejs/node#50820 * esm: do not call getSource when format is commonjs nodejs/node#50465 * esm: fallback to readFileSync when source is nullish nodejs/node#50825 * vm: allow dynamic import with a referrer realm nodejs/node#50360 * test: skip test-diagnostics-channel-memory-leak.js nodejs/node#50327 * esm: do not call getSource when format is commonjs nodejs/node#50465 * lib: fix assert throwing different error messages in ESM and CJS nodejs/node#50634 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * deps: update base64 to 0.5.1 nodejs/node#50629 * src: avoid silent coercion to signed/unsigned int nodejs/node#50663 * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * chore: fix patch indices * chore: update patches * test: disable TLS cipher test This can't be enabled owing to BoringSSL incompatibilities. nodejs/node#50186 * fix: check for Buffer and global definition in shadow realm nodejs/node#51239 * test: disable parallel/test-shadow-realm-custom-loader Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle * chore: remove deleted parallel/test-crypto-modp1-error test * test: make test-node-output-v8-warning generic nodejs/node#50421 * chore: fixup ModuleWrap patch * test: match wpt/streams/transferable/transform-stream-members.any.js to upstream * fix: sandbox is not enabled on arm * chore: disable v8 sandbox on ia32/arm --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be accurate about signedness and bit widths.