Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change forEach to for...of in path extname #50667

Merged
merged 2 commits into from
Nov 13, 2023
Merged

test: change forEach to for...of in path extname #50667

merged 2 commits into from
Nov 13, 2023

Conversation

marquicodes
Copy link
Contributor

Changes forEach loops with for...of.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55560/

@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 11, 2023
@github-actions github-actions bot mentioned this pull request Nov 12, 2023
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55594/

@targos targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 12, 2023
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Open
24 tasks
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 13, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2023
@nodejs-github-bot nodejs-github-bot merged commit ce4a06d into nodejs:main Nov 13, 2023
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ce4a06d

@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Open
25 tasks
targos pushed a commit that referenced this pull request Nov 23, 2023
@marquicodes @targos
test: change forEach to for...of in path extname
342a83e 
PR-URL: #50667
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
martenrichter pushed a commit to martenrichter/node that referenced this pull request Nov 26, 2023
@marquicodes @martenrichter
test: change forEach to for...of in path extname
df43b4c 
PR-URL: nodejs#50667
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@marquicodes @UlisesGascon
test: change forEach to for...of in path extname
bb7d764 
PR-URL: #50667
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marquicodes @nodejs-github-bot @jasnell @targos @marco-ippolito @debadree25