-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix links in Addons docs #5072
Closed
Closed
+22
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put links in a lexical order. Add missing links. Remove duplicates.
LGTM cc @nodejs/documentation |
@@ -215,9 +215,10 @@ illustration of how it can be used. | |||
## Addon examples | |||
|
|||
Following are some example Addons intended to help developers get started. The | |||
examples make use of the V8 APIs. Refer to the online [V8 reference][] for help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, read it wrong :)
Ignore my comments and LGTM. |
LGTM |
1 similar comment
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Feb 4, 2016
Put links in a lexical order. Add missing links. Remove duplicates. PR-URL: #5072 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 13a3685 |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Put links in a lexical order. Add missing links. Remove duplicates. PR-URL: #5072 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 10, 2016
Put links in a lexical order. Add missing links. Remove duplicates. PR-URL: #5072 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Put links in a lexical order. Add missing links. Remove duplicates. PR-URL: #5072 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Put links in a lexical order. Add missing links. Remove duplicates. PR-URL: #5072 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Put links in a lexical order. Add missing links. Remove duplicates. PR-URL: nodejs#5072 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put links in a lexical order. Add missing links. Remove duplicates.
Continuing to fix links, their style, etc.