Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix links in Addons docs #5072

Closed
wants to merge 1 commit into from
Closed

doc: fix links in Addons docs #5072

wants to merge 1 commit into from

Conversation

estliberitas
Copy link
Contributor

Put links in a lexical order. Add missing links. Remove duplicates.

Continuing to fix links, their style, etc.

Put links in a lexical order. Add missing links. Remove duplicates.
@thefourtheye thefourtheye added the doc Issues and PRs related to the documentations. label Feb 4, 2016
@thefourtheye
Copy link
Contributor

LGTM cc @nodejs/documentation

@@ -215,9 +215,10 @@ illustration of how it can be used.
## Addon examples

Following are some example Addons intended to help developers get started. The
examples make use of the V8 APIs. Refer to the online [V8 reference][] for help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, read it wrong :)

@stevemao
Copy link
Contributor

stevemao commented Feb 4, 2016

Ignore my comments and LGTM.

@DavidTPate
Copy link

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

LGTM

jasnell pushed a commit that referenced this pull request Feb 4, 2016
Put links in a lexical order. Add missing links. Remove duplicates.

PR-URL: #5072
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 4, 2016

Landed in 13a3685

@jasnell jasnell closed this Feb 4, 2016
rvagg pushed a commit that referenced this pull request Feb 8, 2016
Put links in a lexical order. Add missing links. Remove duplicates.

PR-URL: #5072
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@estliberitas estliberitas deleted the doc-fix-links-addons branch February 14, 2016 17:05
MylesBorins pushed a commit that referenced this pull request Mar 10, 2016
Put links in a lexical order. Add missing links. Remove duplicates.

PR-URL: #5072
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
Put links in a lexical order. Add missing links. Remove duplicates.

PR-URL: #5072
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
Put links in a lexical order. Add missing links. Remove duplicates.

PR-URL: #5072
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Put links in a lexical order. Add missing links. Remove duplicates.

PR-URL: nodejs#5072
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants