Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for-of in test-webcrypto-export-import-ec #50793

Closed
wants to merge 1 commit into from
Closed

test: replace forEach with for-of in test-webcrypto-export-import-ec #50793

wants to merge 1 commit into from

Conversation

cricciardi
Copy link
Contributor

test: replace forEach with for-of in test-webcrypto-export-import-ec

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 18, 2023
jasnell
jasnell approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a new linting nits

@panva panva added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 20, 2023
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 22, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55860/

@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 24, 2023
RafaelGSS
RafaelGSS reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cricciardi apparently, your commit don't include email and username. Can you --resetAuthor after configuring your git? (git config user.name ...)

@cricciardi
Copy link
Contributor Author

@RafaelGSS I updated my commit with username and password

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55954/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56200/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56307/

@RafaelGSS
Copy link
Member

@cricciardi If you see the commit list you will notice the first commit doesn't belong to your github account, can you fix it, please? Basically, just squash all the commits into one and make sure to run git commit --amend --resetAuthor

@cricciardi
Copy link
Contributor Author

Hi @RafaelGSS,
I try to squash commits and set author with this commands:

git rebase --interactive HEAD~20  (set squash on my commit, pick in other commits, and edit on my first commit)
git commit --amend --author="Chiara Ricciardi <chiara.ricciardi66.cr@gmail.com>" (this command for set author)

But it seems not works. Can you tell me what I do wrong?

@RafaelGSS
Copy link
Member

Hi @RafaelGSS, I try to squash commits and set author with this commands:

git rebase --interactive HEAD~20  (set squash on my commit, pick in other commits, and edit on my first commit)
git commit --amend --author="Chiara Ricciardi <chiara.ricciardi66.cr@gmail.com>" (this command for set author)

But it seems not works. Can you tell me what I do wrong?

You need to set squash in all other commits but the first commit

@marco-ippolito
Copy link
Member

User @cricciardi reached out and asked me to fix the commit

@nodejs-github-bot @cricciardi
deps: update simdutf to 4.0.4
23ea6c8 
PR-URL: nodejs#50772
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cricciardi
Copy link
Contributor Author

Hi @marco-ippolito and @RafaelGSS, I open a new PR #51249

@cricciardi cricciardi closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS left review comments

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cricciardi @nodejs-github-bot @RafaelGSS @marco-ippolito @jasnell @lpinca @panva