test_runner: fixed test object is incorrectly passed to setup()

[pulkit-30]

Fix #48809

pass testStream to setup instead testRoot.

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[rluvaton]

Can you please add a test

[rluvaton]

Well done! thanks

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56073/

[MoLow]

this PR causes a regression:
running a simple test file:

const test = require("node:test");
test("a", () => console.log(1));

on main console is printed with colors

but on this branch the colors are discarded:

I am working on fixing the test that should have caught this

[pulkit-30]

this PR causes a regression:
running a simple test file:

I was also suspecting something, but surprised by the tests 😅

[pulkit-30]

converting this PR to draft. ref: #51064, still working on it 🚀

[MoLow]

createWriteStream is called multiple times for each reporter destination, and in some cases the writeStream is never being closed

[pulkit-30]

@MoLow PTAL.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56498/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56508/

[nodejs-github-bot]

Landed in dad666a

[MoLow]

@pulkit-30 thanks for the hard work 🎉

[pulkit-30]

@pulkit-30 thanks for the hard work 🎉

Thanks a ton! It means a lot.

[koshic]

@MoLow do you plan to backport it to 20.x? Documentation is still incorrect - https://nodejs.org/docs/latest-v20.x/api/test.html#runoptions.

[MoLow]

not every PR needs a manual backport. lets wait for @nodejs/releasers to release a new v20 version and request a backport if needed